Re: [Xen-merge] [PATCH] broken install

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> Christian Limpach <Christian.Limpach@xxxxxxxxxxxx> 06.01.06 11:48:12
>>>
>On Thu, Jan 05, 2006 at 06:01:55PM +0100, Jan Beulich wrote:
>> While part of the previously sent patch was integrated, things
still
>> don't work as expected. Namely is it now impossible to specify an
>> INSTALL_PATH that doesn't end int /boot.
>
>I think it works as expected:
>INSTALL_PATH ending in /boot gets the kernel installed to
$INSTALL_PATH and
>headers installed to $INSTALL_PATH/../usr
>INSTALL_PATH not ending in /boot gets the kernel install to
$INSTALL_PATH/boot
>and headers installed to $INSTALL_PATH/usr
>
>With your patch, the behaviour in the second case would change such
that
>the kernel is at $INSTALL_PATH and headers in $INSTALL_PATH/usr, which
is
>rather odd!?

No, that's the correct way. Whatever INSTALL_PATH is pointing at
(namely e.g. /), this should be the place where the kernel images get
placed. If the boot loader lives in and looks only at /, then the
current way of installing will make the installed images unusable.

The oddity of how the /usr path is determined is the more questionable
part, I just made it that way (in the original patch) to prevent
removing any functionality. Generally I don't think installing header
files should be done together with the kernel (no other part of the
kernel does anything similar). Hence I'd generally favor removing this
part of the installation altogether.

Even beyond that, for consistency the architecture's install.sh should
be used for installing the kernel, primarily to automate
initrd/initramfs generation. I have such a patch in place all the time
locally, and I had posted that long ago to xen-devel. I would be more
than happy if that could also get integrated...

Jan

_______________________________________________
Xen-merge mailing list
Xen-merge@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-merge