Re: [Xen-merge] io_apic.c, part 1

["Martin J. Bligh" <mbligh@xxxxxxxxxx>]

--"Martin J. Bligh" <mbligh@xxxxxxxxxx> wrote (on Monday, August 08, 2005 
09:03:09 -0700):

> 
> 
> --Andi Kleen <ak@xxxxxxx> wrote (on Monday, August 08, 2005 17:53:28 +0200):
> 
>> On Mon, Aug 08, 2005 at 08:43:38AM -0700, Martin J. Bligh wrote:
>>> This just shoves some ifdef wrappers around whole functions to
>>> either not define them, or provide a no-op function instead.
>>> The alternative to this is to split the file, but I tried that,
>>> and it made an unholy mess. Plus it's much nicer for maintainance
>>> to keep the alternative definitions right next to each other, if
>>> it's this trivial.
>> 
>> I would prefer to just replace apic.c/io_apic.c completely with new
>> files in the Xen case and perhaps factor the still needed functions out.
>> That's much better than ifdef mess and apic/io_apic needed some
>> cleanup anyways.
> 
> Try doing it then, and you'll see what a mess it makes ;-)

I'll have another play with it later. Just reluctant to waste yet
more time moving shit around if Andrew isn't going to take the results
upstream.

M.


_______________________________________________
Xen-merge mailing list
Xen-merge@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-merge