[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-ia64-devel] Re: [PATCH] fix vmx_vcpu_flush_tlb_all()



On Fri, Aug 01, 2008 at 10:34:29AM +0900, Kouya Shimura wrote:
> I think that calling ptc_ga_remote_func() during __thash_purge_all()
> is harmless.
> Because all that ptc_ga_remote_func() does is to set the 
> invalid value(1UL << 63) to a tag in vcpu->arch.vtlb. 
> It doesn't affect __thash_purge_all() at all.

Thanks for review.
Looking the code more carefully, I agree with you.


> __thash_purge_all() takes over 10 milliseconds. 
> IMHO, it's not so good to disable interrupts for such a long period.

Yes, 10msec is quite long.


-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.