Re: [Xen-ia64-devel] [patch 00/14] ia64: kexec: Map EFI memory in the same location as Linux v20080714

[Isaku Yamahata <yamahata@xxxxxxxxxxxxx>]

The following patch will remove some warnings.

[IA64] remove warnings

Signed-off-by: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>

diff -r 13613fb8265a xen/arch/ia64/vmx/vmx_vcpu.c
--- a/xen/arch/ia64/vmx/vmx_vcpu.c      Mon Jul 14 19:32:30 2008 +0900
+++ b/xen/arch/ia64/vmx/vmx_vcpu.c      Mon Jul 14 19:32:46 2008 +0900
@@ -199,9 +199,9 @@
 void vmx_switch_rr7(unsigned long rid, void *guest_vhpt,
                     void *shared_arch_info)
 {
-    __get_cpu_var(inserted_vhpt) = guest_vhpt;
-    __get_cpu_var(inserted_vpd) = shared_arch_info;
-    __get_cpu_var(inserted_mapped_regs) = shared_arch_info;
+    __get_cpu_var(inserted_vhpt) = (unsigned long)guest_vhpt;
+    __get_cpu_var(inserted_vpd) = (unsigned long)shared_arch_info;
+    __get_cpu_var(inserted_mapped_regs) = (unsigned long)shared_arch_info;
     __vmx_switch_rr7(rid, guest_vhpt, shared_arch_info);
 }
 
diff -r 13613fb8265a xen/include/asm-ia64/xenpage.h
--- a/xen/include/asm-ia64/xenpage.h    Mon Jul 14 19:32:30 2008 +0900
+++ b/xen/include/asm-ia64/xenpage.h    Mon Jul 14 19:32:46 2008 +0900
@@ -97,7 +97,7 @@
 /* It is sometimes very useful to have unsigned long as result.  */
 #define __va_ul(x)     ({xen_va _v; _v.l = (long) (x); _v.f.reg = -1; _v.l;})
 
-#define __va_efi(x)    ((unsigned long)(x) | __IA64_EFI_CACHED_OFFSET)
+#define __va_efi(x)    ((void*)((unsigned long)(x) | __IA64_EFI_CACHED_OFFSET))
 
 #endif
 #endif /* _ASM_IA64_XENPAGE_H */


On Mon, Jul 14, 2008 at 07:21:38PM +1000, Simon Horman wrote:
> 
> Hi,
> 
> This series is what I believe to be a fairly complete set of patches to map
> EFI memory into the same location that Linux does.  The memory is protected
> by an RID so that it doesn't conflict with domain memory - which also
> protects it from malicious access from HVM domains.
> 
> The primary motivation for this is that EFI memory can only be mapped once
> - a restriction in the EFI specification. Thus for kexec betwen Xen and
> Linux, inluding kdump of Xen (into Linux), EFI memory needs to be mapped in
> the same location in both Xen and Linux.
> 
> 
> This new series includes various minor fixes. As well as
> addressing problems with Windows 2k3 sp2 crashing during install.
> 
> 
> I have tested these patches on a Tiger 4 and RX 2620.
> 
> I am hoping for more reviews and tests :-)
> 
> I recommend testing these patches using:
> 
>   Xen
>   http://xenbits.xensource.com/ext/ia64/xen-unstbale.hg
>   Revision: 17943:eb0fc71cfc72
> 
>   Linux-Xen
>   http://xenbits.xensource.com/ext/ia64/linux-2.6.18-xen.hg
>   Revision: 583:3643a33de277
> 
>   Kexec-Tools
>   git://git.kernel.org/pub/scm/linux/kernel/git/horms/kexec-tools-testing.git
>   Revision: 94afdd9f7ab2b07997f80a297741842f9cdbdc25
> 
>   Linux
>   Revision: 2.6.25-rc3
> 

-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel