Re: [Xen-ia64-devel] [PATCH][3/3] Steal time accounting forPVdomain/IA64 TAKE2

[Isaku Yamahata <yamahata@xxxxxxxxxxxxx>]

On Thu, May 15, 2008 at 06:02:00PM +0900, Atsushi SAKAI wrote:

> consider_steal_time() treats stolentick.
> The stolentick is composed of l->itm_delta + alpha.
> The stolentick can consider the large value(unsigned long).
> So stolentick can take from 0 to unsigned long.
> In this meaning, the value of alpha has no assumption in it.

But consider_stea_time() also sets l->itm_next!
Do you agree that l->itm_next can happen to be smaller than
ia64_get_itc() - l->itm_delta?


> As you suggested, if we consider the case of manu vcpu on one pcpu,
> the alpha value expected to become large value.
> But no problem in it.

Why no probelem?
l->itm_next can become smaller than ia64_get_itc() - l->itm_delta.
It breaks the the assumption of timer_interrupts().

-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel