RE: [Xen-ia64-devel] pv_ops: imntrinsic pv_ops

["Dong, Eddie" <eddie.dong@xxxxxxxxx>]

Isaku Yamahata wrote:
> Hi Eddie.
> 
> I commited some clean ups based on your patch.
> Could you please review it?
> 

It looks like you still prefer to use intermediate symbol 
paravirt_xxxx/ia64_native_xxx to wrap ia64_xxx. In some sense, when
I saw many similar and bulk code in the patch, I feel "dirty". I prefer
we don't touch 
those gcc_intrinsic.h MACROs.

If you don't like the way I wrap it, i.e. MACRO level ifdef /else.
you may just simply provide a new head file
for CONFIG_PARAVIRT which simply use pv_ops.name for all those same 
MACROs.

such as in intrinsic.h:

#ifdef CONFIG_PARAVIRT_GUEST
#include <paravirt_intrinsic.h>
#else 
.... gcc_intrinsic.h or intel_intrinsic.h.


Eddie

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel