Re: [Xen-ia64-devel] [Patch] linux: set memory attribute in inlineasm

[Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>]

Hi, Aron

>Hi Akio,
>
>Akio Takebe wrote:  [Fri Apr 04 2008, 05:44:10AM EDT]
>> @@ -251,7 +251,7 @@ extern void xen_set_eflag(unsigned long)
>>  #define xen_ia64_intrin_local_irq_restore(x)                                
\
>>  {                                                                   \
>>       if (is_running_on_xen()) {                                             
\
>> -    if ((x) & IA64_PSR_I) { xen_ssm_i(); }                          \
>> +    if (x) { xen_ssm_i(); }                                         \
>>      else { xen_rsm_i(); }                                           \
>>      }                                                                       
\
>>      else __ia64_intrin_local_irq_restore((x));                              
\
>
>What does this part do?
Thank you for your review.
Sorry for my confusion.

The (x)&IA64_PSR_I should be not unnecessary part,
because ia64_intrin_local_irq_restore() is always called
via __local_irq_restore(x).
It is the same as __ia64_intrin_local_irq_restore(x)
in include/asm-ia64/gcc_intrin.h.

But since it's a different concept with this title,
I droped the hunk.

Signed-off-by: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>

Best Regards,

Akio Takebe

Attachment: inline_asm_barrier.2.patch
Description: Binary data

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel