[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-ia64-devel] RFC: Remove dead code?


  • To: "xen-ia64-devel" <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>
  • From: "Dong, Eddie" <eddie.dong@xxxxxxxxx>
  • Date: Fri, 1 Feb 2008 13:16:17 +0800
  • Delivery-date: Thu, 31 Jan 2008 21:18:04 -0800
  • List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
  • Thread-index: AchkkZLiO6phkOmDQ2+BbyAOe4c4kg==
  • Thread-topic: RFC: Remove dead code?

The following code is not used anymore, and I think it is also a legacy
issue when people are debugging on SKI simulator.
Should we simplify it?
thx, eddie



diff -r 0e62beb4c36a arch/ia64/xen/Makefile
--- a/arch/ia64/xen/Makefile    Fri Feb 01 09:33:32 2008 +0800
+++ b/arch/ia64/xen/Makefile    Fri Feb 01 12:59:24 2008 +0800
@@ -2,7 +2,7 @@
 # Makefile for Xen components
 #
 
-obj-y := hypercall.o xenivt.o xenentry.o xensetup.o xenpal.o xenhpski.o
\
+obj-y := hypercall.o xenivt.o xenentry.o xensetup.o xenpal.o \
         hypervisor.o util.o xencomm.o xcom_hcall.o \
         xcom_privcmd.o xen_dma.o
 
diff -r 0e62beb4c36a arch/ia64/xen/xenhpski.c
--- a/arch/ia64/xen/xenhpski.c  Fri Feb 01 09:33:32 2008 +0800
+++ /dev/null   Thu Jan 01 00:00:00 1970 +0000
@@ -1,19 +0,0 @@
-#include <linux/kernel.h>
-#include <asm/hypervisor.h>
-
-int
-running_on_sim(void)
-{
-       int i;
-       long cpuid[6];
-
-       for (i = 0; i < 5; ++i)
-               cpuid[i] = xen_get_cpuid(i);
-       if ((cpuid[0] & 0xff) != 'H') return 0;
-       if ((cpuid[3] & 0xff) != 0x4) return 0;
-       if (((cpuid[3] >> 8) & 0xff) != 0x0) return 0;
-       if (((cpuid[3] >> 16) & 0xff) != 0x0) return 0;
-       if (((cpuid[3] >> 24) & 0x7) != 0x7) return 0;
-       return 1;
-}
-

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.