[Xen-ia64-devel] Re: [patch 07/16] Xenification of IA64 Kexec/kdump

[Horms <horms@xxxxxxxxxxxx>]

On Fri, Sep 28, 2007 at 12:46:40PM +0900, Horms wrote:
> On Thu, Sep 27, 2007 at 02:13:28PM -0600, Alex Williamson wrote:
> > On Thu, 2007-09-27 at 16:31 +0900, Simon Horman wrote:
> > > plain text document attachment (ia64-xen-kexec.patch)
> > > Signed-off-by: Zou Nan hai <nanhai.zou_at_intel.com>
> > > Signed-off-by: Tony Luck <tony.luck_at_intel.com>
> > 
> > Hi Simon,
> > 
> >    Seems like this should have your sign-off, right?
> 
> Yes, I think you are right. I'll just add it below the existing ones.
> Let me know if you would prefer if they were removed.

Sorry, I was looking at the wrong file earlier.
I've replaced the existing sign-offs (which were bogus)
with one of my own.

> > >  arch/ia64/kernel/crash.c           |   11 +++++------
> > >  arch/ia64/kernel/relocate_kernel.S |   32 
> > > ++++++++++++++++++++++++++++++++
> > >  arch/ia64/kernel/setup.c           |   12 ++++++++++++
> > >  arch/ia64/xen/xcom_hcall.c         |   31 +++++++++++++++++++++++++++++++
> > >  include/asm-ia64/hypercall.h       |    7 +++++++
> > >  include/asm-ia64/machvec_sn2.h     |    4 ++--
> > 
> > You might double check machvec_sn2 changes, the lines changed seem
> > closer to where they live in current upstream before this patch.
> 
> Thanks, I'll look into that.

Yes, you are right. That change is complete rubbish.
I guess that it must just be an artifact of the development process.
I have removed those offending (offensive :) hunks.
I will repost the patch accordingly.

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel