Re: [Xen-ia64-devel] [patch 07/16] Kexec: Call xen_machine_kexec_register_resources

[Horms <horms@xxxxxxxxxxxx>]

On Wed, Sep 12, 2007 at 03:38:59PM -0600, Alex Williamson wrote:
> On Wed, 2007-09-12 at 17:28 +0900, Simon Horman wrote:
> > plain text document attachment
> > (ia64-kexec-efi_initialize_iomem_resources.patch)
> > For kexec on xen xen_machine_kexec_register_resources() needs
> > to be called at boot time.
> 
> > Index: linux-2.6.18-xen.hg/arch/ia64/kernel/efi.c
> > ===================================================================
> > --- linux-2.6.18-xen.hg.orig/arch/ia64/kernel/efi.c 2007-07-10 
> > 10:57:17.000000000 +0900
> > +++ linux-2.6.18-xen.hg/arch/ia64/kernel/efi.c      2007-07-10 
> > 11:11:09.000000000 +0900
> > @@ -1128,6 +1128,9 @@ efi_initialize_iomem_resources(struct re
> >                          insert_resource(res, &boot_param_res);
> >                     if (crashk_res.end > crashk_res.start)
> >                             insert_resource(res, &crashk_res);
> > +#ifdef CONFIG_XEN
> > +                   xen_machine_kexec_register_resources(res);
> > +#endif
> >  #endif
> 
>   Won't this break transparent paravirt?  Might need a CONFIG_KEXEC too.
> Is kexec supposed to do anything on non-dom0 domains?  If not, wrap it
> in an 'if (is_initial_xendomain())', otherwise use is_running_on_xen().
> Thanks,

Hi Alex,

Although it isn't clear from the patch, the code is gaurded by CONFIG_KEXEC.

As you suggest, xen_machine_kexec_register_resources() needed to
be protected, I have used is_initial_xendomain() as this port
of kexec isn't supposed to do anything on non-privelaged domains (yet).

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel