Re: [Xen-ia64-devel] [patch 05/14] Kexec: partial port of CPU_HOTPLUG

[Alex Williamson <alex.williamson@xxxxxx>]

On Wed, 2007-09-12 at 17:08 +0900, Simon Horman wrote:
> 
> +     /* Ensure that we are not runnable on dying cpu */
> +     /* This is current->cpus_allowed on Linux,
> +      * which may well work completely differently */
> +     old_affinity = current->cpu_affinity;
> +     tmp = (cpumask_t)CPU_MASK_ALL;
> +     cpu_clear(cpu, tmp);

   Is it just me, or does this not do anything at all?

> Index: xen-unstable.hg/xen/include/asm-ia64/linux-xen/linux/cpu.h

README.origin in this directory also needs to be updated.

> ===================================================================
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ xen-unstable.hg/xen/include/asm-ia64/linux-xen/linux/cpu.h        
> 2007-08-08 17:59:07.000000000 +0900
...
> --- xen-unstable.hg.orig/xen/include/asm-ia64/linux/asm/sal.h 2007-08-08 
> 17:51:34.000000000 +0900
> +++ xen-unstable.hg/xen/include/asm-ia64/linux/asm/sal.h      2007-08-08 
> 17:59:07.000000000 +0900
> @@ -856,7 +856,8 @@ extern int ia64_sal_oemcall_nolock(struc
>                                  u64, u64, u64, u64, u64);
>  extern int ia64_sal_oemcall_reentrant(struct ia64_sal_retval *, u64, u64, 
> u64,
>                                     u64, u64, u64, u64, u64);
> -#ifdef CONFIG_HOTPLUG_CPU
> +
> +#if CONFIG_HOTPLUG_CPU

   Why?  The next chunk of code users #ifdef again.

> +static void fix_b0_for_bsp(void)
> +{
> +#ifdef CONFIG_HOTPLUG_CPU
> +     int cpuid;
> +     static int fix_bsp_b0 = 1;
> +
> +     cpuid = smp_processor_id();
> +
> +     /*
> +      * Cache the b0 value on the first AP that comes up
> +      */
> +     if (!(fix_bsp_b0 && cpuid))
> +             return;
> +
> +     fix_bsp_b0 = 0;
> +#endif
> +}

   I'm hoping there's another patch that I haven't read yet that makes
this function useful.

Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel