RE: [Xen-ia64-devel] [Xen-ia64][PATCH] Fix NVRAM data can notbesaved when guest execute "reboot" instruction

["Zhang, Xing Z" <xing.z.zhang@xxxxxxxxx>]

Hi Alex:
        This is new one per you comments. It also fixes NVRAM save when execute 
"xm reboot" in Xend

>-----Original Message-----
>From: Zhang, Xing Z
>Sent: 2007年6月28日 15:07
>To: Zhang, Xing Z; 'Alex Williamson'
>Cc: 'xen-ia64-devel@xxxxxxxxxxxxxxxxxxx'
>Subject: RE: [Xen-ia64-devel] [Xen-ia64][PATCH] Fix NVRAM data can notbesaved
>when guest execute "reboot" instruction
>
>>>definitely the obvious candidate, but we could also make it an
>>>architecture dependent static inline in something like vl.h, where the
>>>overloading occurs now.  The overloading is a nice trick, but a context
>>>dependent function like that seems prone to errors to me.  Thanks,
>>[Wing] You may misunderstand my means. Yes, we can implement a hook in vl.h
>as
>>an inline function. But the hook must call the function 
>>xc_ia64_save_to_nvram()
>>which implemented in xc_ia64_hvm_build.c. And the hook is called by
>>xc_domain_shutdown() which in xc_domain.c. So xc_domain_shutdown() belongs to
>>libxenctrl.so while xc_ia64_save_tonvram() belongs to libxenguest.so.
>>
>>A way is move all NVRAM related functions to libxenctrl.so
>[Wing] I am sorry, it's my misunderstanding. I will redo the patch and send out
>it later.

Attachment: nvram_reboot_fix.patch
Description: nvram_reboot_fix.patch

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel