Re: [PATCH] add paddr_t definition to compile gnttab.c (was Re: [Xen-ia64-devel] [RFC] gnttab unmap_and_replace)

[Jes Sorensen <jes@xxxxxxx>]

>>>>> "Alex" == Alex Williamson <alex.williamson@xxxxxx> writes:

Alex> On Fri, 2007-06-08 at 19:54 +0900, Isaku Yamahata wrote:
>> add paddr_t definition to compile gnttab.c
>> 
>> On Tue, Jun 05, 2007 at 11:35:17AM -0600, Alex Williamson wrote:
>> > 
>> > We could typedef paddr_t as we've done for maddr_t.  We may
>> continue > to get broken by such changes in the future otherwise.
>> The pfn_valid() > change doesn't seem like it should be
>> controversial.  Thanks,

Alex>    Hmm, sn already typedefs paddr_t causing a conflict.  Did
Alex> this patch build for you?  Thanks,

Ewww, I've been trying to get rid of those silly typedefs for years :-(
Guess some of them are still in an old patch queue somewhere.

Adding a paddr_t to Xen is really the wrong thing to do IMHO.
Remember: typedef's considered harmful!

Cheers,
Jes

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel