[Xen-ia64-devel] Re: PATCH: all registers in vcpu_guest_context

[Alex Williamson <alex.williamson@xxxxxx>]

On Wed, 2007-05-30 at 01:40 +0200, Tristan Gingold wrote:
> On Tue, May 29, 2007 at 03:54:32PM -0600, Alex Williamson wrote:
> > Hi Tristan,
> > 
> >    Looks like this patch is causing some problems:
> > 
> > http://xenbits.xensource.com/ext/xen-ia64-unstable.hg?rev/7c176473786b
> > 
> > Most of my machines work with it, but one fails to boot dom0.  That box
> > gets a NaT consumption fault with an IIP well above xen text space.  If
> > I chop the rbs array off the end of the vcpu_guest_context_regs it boots
> > fine.  This gets the structure down to a little over 5k.  I see several
> > places where this structure is allocated on the stack.  Are we blowing
> > up the stack with a 21k+ structure?  Suggestions for a fix?  Thanks,
> This seems to be a good reason.
> As a work-around, you may #if 0 the rbs array because it is not yet used.

   Done.

> After a look the structure is allocated on the stack at two places: when a
> vcpu is started (PV and VTi).  Do you confirm ?

   That sounds about right.

> Because this is not performance critical, we can xmalloc it in these cases.

   Great, thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel