[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-ia64-devel] [PATCH 14/14] memmap: allow huge size efi memory map of real machine



On Thu, 2007-05-31 at 10:51 +0900, Isaku Yamahata wrote:
> I will fix unsigned long cast, size_t and PAGE_MASK.
> For do {} while () loop, see below.
...
> 
> Suppose left_mem << (end - start).
> At first loop, dom_md_end = dom_md_start + left_mem.
> However assign_new_domain0_page() consumes only
> left_mem - image_size which is less than left_mem.
> At second loop
> dom_md_end = dom_md_start + (left_mem of first loop) + image_size.

   Yes, I see now.  When reading through, it's easy to assume
assign_new_domain0_range() will increase d->tot_pages by
dom_md->num_pages >> (PAGE_SHIFT - EFI_PAGE_SHIFT).  Thanks,

        Alex
-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.