[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-ia64-devel] [patch] SN2 specific SAL calls for dom0



On Wed, 2007-02-28 at 14:55 +0100, Jes Sorensen wrote:
> +           case SN_SAL_GET_MASTER_NASID:
> +               if (current->domain == dom0) {
> +                       printk("*** Emulating SN_SAL_GET_MASTER_NASID
> ***\n");
> +                       SAL_CALL_NOLOCK(ret_stuff,
> SN_SAL_GET_MASTER_NASID,
> +                                       0, 0, 0, 0, 0, 0, 0);
> +                       status = ret_stuff.status;
> +                       r9 = ret_stuff.v0;
> +                       r10 = ret_stuff.v1;
> +                       r11 = ret_stuff.v2;
> +                       break;
> +               } 

   Seems like these should break at the end regardless of whether it was
called from dom0.  Otherwise another case might sneak in that it could
fall into and do something bad.  Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.