Re: [Xen-ia64-devel] Small bug in handling of domU's itc ops

[Alex Williamson <alex.williamson@xxxxxx>]

On Fri, 2006-12-15 at 13:55 +0100, Dietmar Hahn wrote:
> diff -r 2fc3392d0889 -r a9ea368e59a5 xen/arch/ia64/xen/vcpu.c
> --- a/xen/arch/ia64/xen/vcpu.c        Thu Dec 14 09:56:41 2006 -0700
> +++ b/xen/arch/ia64/xen/vcpu.c        Fri Dec 15 13:35:36 2006 +0100
> @@ -2162,6 +2162,7 @@ vcpu_itc_no_srlz(VCPU * vcpu, u64 IorD, 
>       BUG_ON(logps > PAGE_SHIFT);
>       vcpu_tlb_track_insert_or_dirty(vcpu, vaddr, entry);
>       psr = ia64_clear_ic();
> +     pte &= ~((0x3UL<<50) | 0x1<<1); // Mask out the reserved bits.
>       ia64_itc(IorD, vaddr, pte, ps); // FIXME: look for bigger mappings
>       ia64_set_psr(psr);
>       // ia64_srlz_i(); // no srls req'd, will rfi later

Hi Dietmar,

   This looks ok, but I would prefer to have a macros of the reserved
bitmask in a header somewhere.  Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel