Re: [Xen-ia64-devel] [PATCH] pal_halt_light emulate for domU TAKE3

[Isaku Yamahata <yamahata@xxxxxxxxxxxxx>]

On Tue, Aug 22, 2006 at 05:28:54PM +0900, Atsushi SAKAI wrote:

> So this patch does not need to add vcpu_pend_timer fixes.

O.K.
So the modification of vcpu_pend_timer() is unnecessary for the patch.


> But this should be fixed in sometime.

Does you mean that the following hank is still needed?
Why? What issue does the change resolve?

@@ -1167,8 +1167,8 @@ void vcpu_pend_timer(VCPU *vcpu)
                 * handler has not been registered. Don't fire in such case.
                 */
                if (vcpu->virq_to_evtchn[VIRQ_ITC]) {
+                       PSCBX(vcpu, domain_itm_last) = PSCBX(vcpu, domain_itm);
                        send_guest_vcpu_virq(vcpu, VIRQ_ITC);
-                       PSCBX(vcpu, domain_itm_last) = PSCBX(vcpu, domain_itm);
                }
        } else
                vcpu_pend_interrupt(vcpu, itv);
-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel