Re: [Xen-ia64-devel] [PATCH] increase buffer size in panic_domain()

[Isaku Yamahata <yamahata@xxxxxxxxxxxxx>]

On Tue, Jul 25, 2006 at 09:47:39AM -0600, Alex Williamson wrote:
> On Tue, 2006-07-25 at 13:02 +0900, Isaku Yamahata wrote:
> > --- a/xen/arch/ia64/xen/xenmisc.c       Mon Jul 24 21:25:30 2006 +0900
> > +++ b/xen/arch/ia64/xen/xenmisc.c       Mon Jul 24 21:25:30 2006 +0900
> > @@ -172,7 +172,7 @@ void panic_domain(struct pt_regs *regs, 
> >  void panic_domain(struct pt_regs *regs, const char *fmt, ...)
> >  {
> >         va_list args;
> > -       char buf[128];
> > +       static char buf[1024]; 
> 
> Hi Isaku,
> 
>    The static here will cause problems if panic_domain() is called
> concurrently from multiple CPUs.  Thanks,

You're right. How about this patch?
panic_domain() should be simple so that I wouldn't like to play 
with SMP here.
Given that stack size is 16KB for both normal and RSE stack,
256 bytes would be acceptable.
In fact I hit this issue with void check_bad_nested_interruption().
256 bytes is sufficient for now.

-- 
yamahata

Attachment: 10751:23fc30baae32_increase_buffer_in_panic_domain-1.patch
Description: Text document

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel