Re: [Xen-ia64-devel] [patch 4/4] fix debug=y build: fix refs to in_irq

[Tristan Gingold <Tristan.Gingold@xxxxxxxx>]

Le Vendredi 02 Juin 2006 16:51, Aron Griffis a Ãcrit :
> I don't actually have a patch for this problem yet, but I'll describe
> the problem and maybe somebody will have a quick fix.
>
> In xen/common/page_alloc.c and xen/common/schedule.c, there's a number
> of these:
>
>     ASSERT(!in_irq());
>
> This *should* work fine on ia64, but the problem is that the include
> trail is mixed up.  On x86, it goes like this:
>
>     #include <xen/irq.h>     --> include/xen/irq.h
>     #include <asm/irq.h>     --> include/asm-x86/irq.h
>     #include <asm/hardirq.h> --> include/asm-x86/hardirq.h
>
>     and hardirq.h defines in_irq()
>
> On ia64 it goes like this instead:
>
>     #include <xen/irq.h>     --> include/xen/irq.h
>     #include <asm/irq.h>     --> include/asm-ia64/linux/asm/irq.h
>     #include <asm/hardirq.h> --> include/asm-ia64/linux/asm/hardirq.h
>
>     but in_irq() is defined in a *different* hardirq.h which lives at
>     include/asm-ia64/linux-xen/linux/hardirq.h
>
> Any suggestions on the best way to handle this?  If you want to see it
> break for yourself, apply the first three patches in this patch bomb,
> then "cd xen; make debug=y"
Yes, I once tried to fix debug=y, but stopped after that.

I think the best solution is to create an asm-ia64/hardirq.h from 
linux-xen/linux/hardirq.h and linux/asm/hardirq.h

Xen/ia64 was heavily leveraged from Linux, but I think it's time to slowly go 
away.

Just my 0.02 eurs :-)

Tristan.

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel