[Xen-ia64-devel] [RFC] cleanup warning (redefine MMIO_SIZE)

[Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>]

Hi, all

This issue is only for fedora-xen-ia64.
fedora-xen-ia64 turn on CONFIG_FB_NEOMAGIC in .config.
(xen-ia64-unstable is default turn off it)
In the case of CONFIG_FB_NEOMAGIC=y, MMIO_SIZE is redefine.
I think MMIO_SIZE in arch-ia64.h is only used 
in arch-ia64.h and xen/arch/ia64/vmx/vmx_init.c.
Am I right?

We should move some defines(e.g. MMIO_xxx) from public header
to not public header because they are used only 
in vmx_init.c, shouldn't we?

fedora-xen-ia64's warning is:
In file included from drivers/video/neofb.c:85:
include/video/neomagic.h:136:1: warning: "MMIO_SIZE" redefined
In file included from include/xen/interface/xen.h:17,
                 from include/asm/hypervisor.h:41,
                 from include/asm/page.h:246,
                 from include/asm/ptrace.h:86,
                 from include/asm/processor.h:20,
                 from include/asm/thread_info.h:11,
                 from include/linux/thread_info.h:21,
                 from include/linux/preempt.h:10,
                 from include/linux/spinlock.h:50,
                 from include/linux/capability.h:45,
                 from include/linux/sched.h:7,
                 from include/linux/module.h:10,
                 from drivers/video/neofb.c:58:
include/xen/interface/arch-ia64.h:71:1: warning: this is the location of 
the previous definition

Best Regards,

Akio Takebe


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel