[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-ia64-devel][PATCH] Enable SMP on VTI domain.


  • To: "Isaku Yamahata" <yamahata@xxxxxxxxxxxxx>
  • From: "Xu, Anthony" <anthony.xu@xxxxxxxxx>
  • Date: Thu, 1 Jun 2006 12:55:08 +0800
  • Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 31 May 2006 21:56:13 -0700
  • List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
  • Thread-index: AcaFNh4LAHsLj9d5Q1+96sFDIvOEZgAAKpiA
  • Thread-topic: [Xen-ia64-devel][PATCH] Enable SMP on VTI domain.

>From: Isaku Yamahata [mailto:yamahata@xxxxxxxxxxxxx]
>Sent: 2006?6?1? 12:45
>> >I just took a quick look at your patch though.
>> >There is no protection to IPI.
>> >Is it O.K? Does the use of IPI cause race?
>> >
>> Do you mean below code?
>> #ifdef XEN
>>      spin_lock(&call_lock);
>> #else
>
>I meant local_irq_save(), local_irq_restore(). masking ipi.
>
I'm not sure.
But I don't think it is needed, otherwise how a LP sends IPI to itself.
>
>> Or you mean the protection of global purge.
>> When a vcpu get IPI to purge TLB,
>> What it does is to invalid the TLB entry in VHPT,
>> but not remove the TLB entry.
>> There is no race condition.
>
>Is there any gurantee that the vcpu which recives IPI isn't touching VHPT?

The vcpu which receives IPI can touch VHPT in the same time.
Because purge operation only sets the TLB entry invalid, like entry->ti=1.
That has the same philosophy with Tristan's direct purge


>
>--
>yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.