Re: [Xen-ia64-devel] XEN_HYPER_ITC_D and XEN_HYPER_ITC_I in vhpt_miss

[Tristan Gingold <Tristan.Gingold@xxxxxxxx>]

Le Mardi 23 Mai 2006 16:04, Magenheimer, Dan (HP Labs Fort Collins) a écrit :
> > Le Mardi 23 Mai 2006 13:53, Dietmar Hahn a écrit :
> > > Hi,
> > >
> > > while I was trying to understand the trap handler in
> > > linux-2.6-xen-sparse/arch/ia64/xen/xenivt.S
> > > I saw the lines 205 ff:
> > >
> > > #ifdef CONFIG_XEN
> > >   mov r24=r8
> > >   mov r8=r18
> > >   ;;
> > > (p10)     XEN_HYPER_ITC_D
> > >   ;;
> > > (p11)     XEN_HYPER_ITC_I
> > >   ;;
> > >   mov r8=r24
> > >   ;;
> > > #else
> > > (p10)     itc.i r18                               //
> >
> > insert the instruction TLB entry
> >
> > > (p11)     itc.d r18                               //
> >
> > insert the data TLB entry
> >
> > > #endif
> > >
> > > May it be that XEN_HYPER_ITC_D and XEN_HYPER_ITC_I are in
> >
> > the reverse
> >
> > > order?
> >
> > Good catch.
> >
> > Feel free to send a patch.
>
> Does this code ever get executed?  The VHPT is pinned by
> a TR, correct?
For sure it is strange we never hit this bug ;-)

Tristan.

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel