RE: [Xen-ia64-devel] [PATCH] [RESEND] SetVirtualAddressMap emulationsupport

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

>From:Masaki Kanno
>Sent: 2006年5月1日 18:06
>Hi,
>
>I reflected comment for this patch.
>I confirmed that GetTime(), ResetSystem() and SetVirtualAddressMap()
>emulation worked.
>
>Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
>
>Best regards,
> Kan

Hi, Kan,
        Good work and small comments here:

- It's more natural to have errno as return value with meaningful result 
passed by pointer, say:
+static unsigned long
+efi_translate_domain_addr(unsigned long domain_addr, IA64FAULT 
*fault)
Better as:
Static IA64FAULT efi_translate_domain_addr(unsigned long 
domain_addr, unsigned long *addr)

- +             if (copy_from_user(&entry, p, sizeof(efi_memory_desc_t))) {
+                       printf ("efi_emulate_set_virtual_address_map: 
copy_from_user() fault. addr=0x%p\n", p);
+                       return EFI_UNSUPPORTED;
+               }
+
+               md = p;

Seems you may want to use &entry here instead of continuing reference 
to guest pointer. :-)

Thanks,
Kevin

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel