[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-ia64-devel] assign_domain_page vs assign_new_domain_page


  • To: "Tristan Gingold" <Tristan.Gingold@xxxxxxxx>, <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>
  • From: "Magenheimer, Dan (HP Labs Fort Collins)" <dan.magenheimer@xxxxxx>
  • Date: Wed, 22 Mar 2006 10:36:27 -0800
  • Delivery-date: Wed, 22 Mar 2006 18:37:56 +0000
  • List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
  • Thread-index: AcZNmuCXO0yru66/R5iz1VfQkDs4HgAQ+BHg
  • Thread-topic: [Xen-ia64-devel] assign_domain_page vs assign_new_domain_page

These functions were recently renamed because the old
names were confusing.  I'm not sure the new names are
any better...

IIRC assign_new_domain_page was written for and is primarily
used by non-VTI.  assign_domain_page was written for and
is primarily used by VTI.  There was no need for an
mpt_table for non-VTI and I'm not sure if it is fully
used yet even by VTI.  I think what is there is a partial
implementation intended to be used with p2m.

I think before the VTI/non-VTI merge, there were more
differences but now it might make sense to merge the two. 

> -----Original Message-----
> From: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx 
> [mailto:xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf 
> Of Tristan Gingold
> Sent: Wednesday, March 22, 2006 3:29 AM
> To: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
> Subject: [Xen-ia64-devel] assign_domain_page vs assign_new_domain_page
> 
> Hi,
> 
> I think assign_new_domain_page should basically be allocating 
> a page + calling 
> assign_domain_page.
> 
> However assign_domain_page updates mpt_table while 
> assign_new_domain_page 
> doesn't.  Why ?  Is it a bug ?
> 
> Tristan.
> 
> 
> 
> 
> _______________________________________________
> Xen-ia64-devel mailing list
> Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-ia64-devel
> 

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.