[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-ia64-devel] [PATCH] Clean up warnings related to VTi code.


  • To: "Masaki Kanno" <kanno.masaki@xxxxxxxxxxxxxx>
  • From: "Zhang, Xiantao" <xiantao.zhang@xxxxxxxxx>
  • Date: Mon, 27 Feb 2006 11:42:32 +0800
  • Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 27 Feb 2006 03:43:12 +0000
  • List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
  • Thread-index: AcY7OAmTk8qwTLo8Qey7rhVIaEcsTwAFqqrg
  • Thread-topic: [Xen-ia64-devel] [PATCH] Clean up warnings related to VTi code.

Hi Kan,
        This patch was made several days ago, and the file 
xen/include/xen/hypercall.h didn't exist then, so I couldn’t find this issue 
before sending out. This issue doesn't impact compiling, and I will send out a 
small patch to fix it.
Thanks very much!
     Xiantao
CSD-OTC PRC Virtualization 
Intel (China) Limited 
> -----Original Message-----
> From: Masaki Kanno [mailto:kanno.masaki@xxxxxxxxxxxxxx]
> Sent: 2006年2月27日 8:52
> To: Zhang, Xiantao
> Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-ia64-devel] [PATCH] Clean up warnings related to VTi code.
> 
> Hi Xiantao/Kevin,
> 
> Sorry. it is too late, but I have one comment.
> "extern do_sched_op()" is declared in xen/include/xen/hypercall.h.
> 
> diff -r 111af742e414 xen/arch/ia64/vmx/vmx_hypercall.c
> --- a/xen/arch/ia64/vmx/vmx_hypercall.c       Sun Feb 19 04:25:31 2006
> +++ b/xen/arch/ia64/vmx/vmx_hypercall.c       Fri Feb 24 10:16:17 2006
> @@ -31,6 +31,11 @@
>  #include <xen/mm.h>
>  #include <xen/multicall.h>
>  #include <xen/hypercall.h>
> +#include <public/version.h>
> +#include <asm/dom_fw.h>
> +#include <xen/domain.h>
> +
> +extern long do_sched_op(int cmd, unsigned long arg);
> 
> Best regards,
>  Kan
> 
> Zhang, Xiantao wrote:
> >Hi Dan/Alex,
> >These two patches intend to clean up lots of warnings related to VTi
> >code.
> >
> >1. clean_up_warnings_c_file.patch removes  most of the warnings such as
> >incompatible assignment, unused variables, return value type of some
> >functions  and so on.
> >
> >2. clean_up_warnings_header_file.patch adds some functions' prototype
> >declaration in corresponding header file and removes issues redefinition
> >of some macros.
> >Currently lots of warnings even errors have impacted debugging severely,
> >so it's time to solve this issue.
> >Please help to check in.
> >Signed-off-by : Zhang Xiantao <Xiantao.zhang@xxxxxxxxx>
> >Signed-off-by : Kevin Tian    <Kevin.tian@xxxxxxxxx>
> >             Thanks
> >     Xiantao Zhang
> >CSD-OTC PRC Virtualization
> >Intel (China) Limited
> >______________________________________________________________________
> >
> >_______________________________________________
> >Xen-ia64-devel mailing list
> >Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
> >http://lists.xensource.com/xen-ia64-devel

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.