Re: [Xen-ia64-devel] [PATCH] added multicall

[Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>]

Hi, Tristan

Thank you for advice. Please give me advice once again.
I was not able to find an appropriate common header. In which header
do you define them in case of you?
 - xen/hypercall.h (new)
 - xen/multicall.h
 - asm/multicall.h
 - etc

I think xen/hypercall.h is better.

Best regards,
 Kan

Tristan Gingold wrote:
>Le Mercredi 25 Janvier 2006 13:09, Masaki Kanno a 馗rit :
>> Hi,
>>
>> This patch added multicall hypercall.
>> The xm top command succeeded.
>>
>> Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
>>
>> Best regards,
>>  Kan
>Hi,
>
>I personnaly think that these declarations
>+extern long do_ni_hypercall(void);
>+extern long do_dom0_op(dom0_op_t *u_dom0_op);
>+extern long do_memory_op(int cmd, void *arg);
>+extern long do_multicall(multicall_entry_t *call_list, unsigned int 
>nr_calls);
>+extern long do_event_channel_op(evtchn_op_t *uop);
>+extern long do_xen_version(int cmd, void *arg);
>+extern long do_console_io(int cmd, int count, char *buffer);
>+extern long do_grant_table_op(unsigned int cmd, void *uop, unsigned int 
>count);
>
>should go in common headers.  They will be checked with definitions and this 
>will avoid to re-declare them in some other files.
>
>Tristan.
>
>


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel