Re: [Xen-ia64-devel] Problem with xen-unstable cset 7937 (grant tabletransfer fix)

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 22 Nov 2005, at 13:09, Magenheimer, Dan (HP Labs Fort Collins) wrote:

> > No patch!
> Oops!  Attached is the whole file which, since this isn't proposed
> as a patch to apply yet, might be easier to peruse.
>
> The only changes are the addition of __ia64__ conditional
> compile directives.
Looking through, you're correct that some of the macro definitions 
should be in an arch-specific header file. Also, the code that 
sets/clears PTEs can be abstracted a little more (much of the work is 
already done in arch/x86/mm.c, and we can make it do a little more).
However, I see no need to ifdef the code that uses pfn_valid, 
get_page[_type] and put_page[_type]. They are easily noop'ed if they 
mean nothing on ia64 (in fact I notice that you already define them). I 
would imagine that at least pfn_valid() makes sense though?
Apart from that, I also didn't understand the changes in the block 
commented 'fundamental difference here'.
But looks to me like we ought to be able to move ia64 onto common 
grant_table.c implementation fairly easily. We should shoot down a few 
of the easy ifdefs first though.
 -- Keir


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel