RE: [Xen-ia64-devel] RE: [Xen-devel] [PATCH][RESEND] Control panelchanges for IA64/VTI

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

Thanks for trying it out and failed hunks mainly came from change from 
u32->uint32_t. Attached new version based on latest xen-ia64-unstable.hg (Rev 
7499).

Thanks,
Kevin

>-----Original Message-----
>From: Magenheimer, Dan (HP Labs Fort Collins) [mailto:dan.magenheimer@xxxxxx]
>Sent: 2005年10月25日 1:45
>To: Tian, Kevin
>Cc: Xen-IA64-Devel
>Subject: RE: [Xen-ia64-devel] RE: [Xen-devel] [PATCH][RESEND] Control
>panelchanges for IA64/VTI
>
>Could you regen the vti_cp and vti_cp_common patches?
>After the merge with xen-unstable, many hunks fail
>to apply and I am hesitant to apply them by hand
>as I may break them and I am not able to test them.
>
>Thanks,
>Dan
>
>> -----Original Message-----
>> From: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
>> [mailto:xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf
>> Of Tian, Kevin
>> Sent: Monday, October 24, 2005 4:55 AM
>> To: Ewan Mellor
>> Cc: Keir Fraser; xen-devel@xxxxxxxxxxxxxxxxxxx; Xen-IA64-Devel
>> Subject: [Xen-ia64-devel] RE: [Xen-devel] [PATCH][RESEND]
>> Control panelchanges for IA64/VTI
>>
>> Ewan, thanks for pointing out following obvious error, and I
>> need to make patch more carefully next time. ;-)
>>
>> Attached the updated version. To reduce the mail size, I
>> skipped attaching the other untouched one.
>>
>> Thanks,
>> Kevin
>>
>> >From: Ewan Mellor [mailto:ewan@xxxxxxxxxxxxx]
>> >Sent: 2005年10月24日 18:07
>> >On Mon, Oct 24, 2005 at 09:19:33AM +0800, Tian, Kevin wrote:
>> >
>> >> >From: Keir Fraser [mailto:Keir.Fraser@xxxxxxxxxxxx]
>> >> >
>> >> >The patches look okay, although the Python bits aren't
>> particularly
>> >> >pretty.
>> >> >
>> >> >  -- Keir
>> >>
>> >> Sorry for bad Python skill. ;-) So Dan, please help check in.
>> >
>> >Actually executing your code would be a good start.
>> >
>> >--- a/tools/python/xen/xend/image.py        Sat Oct 15 03:09:43 2005
>> >+++ b/tools/python/xen/xend/image.py        Fri Oct 21 15:35:26 2005
>> >@@ -58,6 +58,7 @@
>> >     """
>> >
>> >     ostype = None
>> >+    page_kb = 4
>> >
>> >
>> >     def __init__(self, vm, imageConfig, deviceConfig):
>> >@@ -366,11 +367,13 @@
>> >
>> >     def getDomainMemory(self, mem):
>> >         """@see ImageHandler.getDomainMemory"""
>> >+   if os.uname[4] == 'ia64':
>> >+       page_kb = 16
>> >         # for ioreq_t and xenstore
>> >         static_pages = 2
>> >
>> >This is going to fail with a TypeError exception, because
>> os.uname is a
>> >function.  You want os.uname()[4].
>> >
>> >Ewan.
>>

Attachment: patch_vti_cp_common
Description: patch_vti_cp_common

Attachment: patch_vti_cp
Description: patch_vti_cp

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel