[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 2/2] x86/passthrough: skip disabled vLAPICs in vector_hashing_dest()


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Stefano Stabellini <stefano.stabellini@xxxxxxx>
  • Date: Thu, 19 Nov 2026 14:00:02 -0800
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ybpWGRnz0YgzptcCH56dZZXiEu2ZDPhCyBMsUrxtBHU=; b=UHo2phCeEC2PG3XGJga5qpCtjKjwWtUGjdmANNLoGTXtXih4ib75kRcOfO4VoiecGvNQaj0kDv6ETNhlSEwlxGvqa/S0WG8v6M7lHpPjsjBvKrkQMsTHgUW9OHuLPatru3SpfMBDLXA6Ff3e1OBANVjZlLuAp3Ujkl0Kw8tXxmbm9HkP/TvGC9mU0nB3hkR1CbIUyKf1zwxkhUwYJEvG/qMDtOXk3BSVnGEpJUFI62Zx/VX+SW2c3CoRFs8sr8fHeDeQGMH86l22Zg3ZaGdpw6w61qINVhQ6CM8s17u5lxteTmOL47MNQmMRzmf4aPJFj7PIHrIbFyOO//KrBKDTZA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=E7UVm59cPywdjorlKL+nDl3NBxaRa06a8OD+aXQpCelss6ANQI1xTaD60mQYQS8NKADbQ8yraWWsbB3Z3TJSrCEAKGlkNITTihkvPr3x+nCrNtBC7lMCRHmlfDVqFXPt6L6dwo3CMn2pfCK7BcGvzfTraIeTrNduqzcrhbs5NESPlpeqUZd6cE10rXxrqSkI7GUFvC8WB4TEriWM6FhzpTcG2lR/Q8wCA1jmQq6J3SNpE1sSewwHXRZliVk3+ymhCtg9C8CDNOPLC1sM3BII0LmYO42PEByW7SqIp5Xsoqa3DjGmlnxl46H8yoxK/yC7+Y7WDBlMD+G9YnQzmxKNEQ==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Cc: <stefano.stabellini@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>
  • Delivery-date: Thu, 19 Nov 2026 22:00:23 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Unlike vlapic_lowest_prio(), vector_hashing_dest() does not check
vlapic_enabled(), so a lowest-priority MSI can be posted to a vCPU
whose LAPIC is disabled, e.g. an AP not yet started, and the interrupt
is left pending in that vCPU's PIR instead of being delivered.

Skip such vCPUs, as vlapic_lowest_prio() does, and as vioapic_deliver()
already mimics where it uses vlapic_match_dest() on its own.

Fixes: 35a1caf8b6b5 ("pass-through: update IRTE according to guest interrupt 
config changes")
Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxx>
---
CC: Jan Beulich <jbeulich@xxxxxxxx>
CC: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CC: Roger Pau Monné <roger@xxxxxxxxxxxxxx>
CC: Teddy Astie <teddy.astie@xxxxxxxxxx>

 xen/drivers/passthrough/x86/hvm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/xen/drivers/passthrough/x86/hvm.c 
b/xen/drivers/passthrough/x86/hvm.c
index 9f8e6c8cd5..7971acadbc 100644
--- a/xen/drivers/passthrough/x86/hvm.c
+++ b/xen/drivers/passthrough/x86/hvm.c
@@ -191,7 +191,8 @@ static struct vcpu *vector_hashing_dest(const struct domain 
*d,
     for_each_vcpu ( d, v )
     {
         if ( !vlapic_match_dest(vcpu_vlapic(v), NULL, APIC_DEST_NOSHORT,
-                                dest_id, dest_mode) )
+                                dest_id, dest_mode) ||
+             !vlapic_enabled(vcpu_vlapic(v)) )
             continue;
 
         __set_bit(v->vcpu_id, dest_vcpu_bitmap);
-- 
2.47.3




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.