[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] x86/vlapic: accept a logical destination of all ones as a broadcast



On Thu, 19 Nov 2026, Jan Beulich wrote:
> On 18.11.2026 00:36, Stefano Stabellini wrote:
> > In logical destination mode, a destination of all ones is a broadcast
> > accepted by every local APIC: 0xff in xAPIC mode, in both the flat and
> > the cluster model (AMD APM vol. 2, "Receiving System and IPI
> > Interrupts"), and 0xffffffff in x2APIC mode (AMD APM vol. 2, "x2APIC
> > Interrupt Command Register (ICR) Operations").
> > 
> > vlapic_match_logical_addr() treated these as ordinary logical
> > destinations, so a broadcast reached only the vLAPICs whose logical ID
> > happened to match it. In particular, a vLAPIC whose logical ID is 0
> > received no logical broadcast at all.
> > 
> > Check for the broadcast in vlapic_match_dest() before telling the two
> > destination modes apart, as was already done for physical destinations.
> > A vLAPIC whose destination format register names neither model now
> > also accepts the broadcast.
> > 
> > Fixes: f9e0cccf7b35 ("x86/HVM: fix ID handling of x2APIC emulation")
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxx>
> > ---
> > CC: Jan Beulich <jbeulich@xxxxxxxx>,
> > CC: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>,
> > CC: Roger Pau Monné <roger@xxxxxxxxxxxxxx>,
> > CC: Teddy Astie <teddy.astie@xxxxxxxxxx>
> > 
> > v2:
> >  - Check for the broadcast once in vlapic_match_dest(), before the two
> >    destination modes are told apart, rather than in each model of
> >    vlapic_match_logical_addr() (Jan). As a result, a logical broadcast
> >    now also matches a vLAPIC whose DFR names neither model.
> >  - Cite the AMD APM by section title (Jan).
> >  - Add Fixes: tags.
> > 
> >  xen/arch/x86/hvm/vlapic.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c
> > index 6698779e22..50b515d254 100644
> > --- a/xen/arch/x86/hvm/vlapic.c
> > +++ b/xen/arch/x86/hvm/vlapic.c
> > @@ -247,10 +247,12 @@ bool vlapic_match_dest(
> >      switch ( short_hand )
> >      {
> >      case APIC_DEST_NOSHORT:
> > +        /* All ones is a broadcast in either destination mode. */
> > +        if ( dest == _VLAPIC_ID(target, 0xffffffffU) )
> 
> Turns out a very similar patch (referencing the SDM rather than the APM)
> was sent before, and Andrew pointed out an issue there [1]: This needs to
> use the sender, not the receiver, to determine whether broadcast is meant.
> 
> Jan
> 
> [1] 
> https://lore.kernel.org/xen-devel/95e0e0fb-2978-4c87-b723-fb7c30f36883@xxxxxxxxxx/

I'll send out a new patch to address this



> > +            return true;
> >          if ( dest_mode )
> >              return vlapic_match_logical_addr(target, dest);
> > -        return (dest == _VLAPIC_ID(target, 0xffffffffU)) ||
> > -               (dest == VLAPIC_ID(target));
> > +        return dest == VLAPIC_ID(target);
> >  
> >      case APIC_DEST_SELF:
> >          return (target == source);
> 

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.