|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v8 23/26] docs/fusa: add NS16x50 UART requirements for x86
Hi Denis, The requirements look good. And it is great that you have written the tests as well. So from a FuSa perspective, these requirements are 'covered'. I want to confirm the tests for each of the requirements. Refer "[XTF PATCH v1 6/6] x86: add NS16550-compatible emulator test" On 11/11/2026 19:47, dmukhin@xxxxxxxx
wrote:
Is this tested by test_scr() ? And ..From: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx> Add the market-to-design traceability chain for the emulated NS16550-compatible UART exposed to x86 domains. The design requirements are written one per row of the test_suite[] array in the XTF test tests/emul-ns16x50/main.c, so that each requirement is covered by a test case. Additionally, document the assumptions Xen makes on the domain in order to provide the functionality. Introduce XenProd~x86_emulated_uart~1 as the product requirement the design requirements cover, and add the two new documents to the toctree. Finally, fill in the maintainer of the FUSA (x86) entry and extend it to cover the x86 product requirements. Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx> Signed-off-by: Denis Mukhin <dmukhin@xxxxxxxx> --- MAINTAINERS | 7 + docs/fusa/reqs/design-reqs/x86/ns16x50.rst | 386 +++++++++++++++++++++ docs/fusa/reqs/index.rst | 2 + docs/fusa/reqs/product-reqs/x86/reqs.rst | 24 ++ 4 files changed, 419 insertions(+) create mode 100644 docs/fusa/reqs/design-reqs/x86/ns16x50.rst create mode 100644 docs/fusa/reqs/product-reqs/x86/reqs.rst diff --git a/MAINTAINERS b/MAINTAINERS index 327adf4641a1..2c0eaaea2d24 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -335,6 +335,13 @@ F: xen/arch/x86/include/asm/x86_*/efi*.h F: xen/common/efi/ F: xen/include/efi/ +FUSA (x86) +M: Denis Mukhin <dmukhin@xxxxxxxx> +R: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx> +S: Supported +F: docs/fusa/reqs/design-reqs/x86 +F: docs/fusa/reqs/product-reqs/x86 + FUSA M: Stefano Stabellini <sstabellini@xxxxxxxxxx> M: Bertrand Marquis <bertrand.marquis@xxxxxxx> diff --git a/docs/fusa/reqs/design-reqs/x86/ns16x50.rst b/docs/fusa/reqs/design-reqs/x86/ns16x50.rst new file mode 100644 index 000000000000..e3995dc9defc --- /dev/null +++ b/docs/fusa/reqs/design-reqs/x86/ns16x50.rst @@ -0,0 +1,386 @@ +.. SPDX-License-Identifier: CC-BY-4.0 + +NS16550-compatible UART Emulation +================================= + +The following are the requirements related to NS16550-compatible UART emulated +and exposed by Xen x86 domains. + +Access UART scratch register +---------------------------- + +`XenSwdgn~emul_ns16x50_scr~1` + +Description: +Xen shall emulate a scratch register for read/write. test_thr()+ +Rationale: + +Comments: + +Covers: + - `XenProd~emul_ns16x50~1` + +Access Transmit Holding Register +-------------------------------- + +`XenSwdgn~emul_ns16x50_thr~1` + +Description: +Xen shall emulate a transmit holding register. test_lcr()+ +Rationale: + +Comments: + +Covers: + - `XenProd~emul_ns16x50~1` + +Access Line Control Register +---------------------------- + +`XenSwdgn~emul_ns16x50_lcr~1` + +Description: +Xen shall emulate a line control register for read/write. test_ier()+ +Rationale: + +Comments: + +Covers: + - `XenProd~emul_ns16x50~1` + +Access Interrupt Enable Register +-------------------------------- + +`XenSwdgn~emul_ns16x50_ier~1` + +Description: +Xen shall emulate an interrupt enable register for read/write. test_divisor_latch()+ +Rationale: + +Comments: + +Covers: + - `XenProd~emul_ns16x50~1` + +Access divisor latch registers to support various baud rates +------------------------------------------------------------ + +`XenSwdgn~emul_ns16x50_divisor_latch~1` + +Description: +Xen shall emulate the divisor latch low and divisor latch high registers to +support baud rates - 50, 75, 110, 134.5, 150, 300, 600, 1200, 1800, 2000, +2400, 3600, 4800, 7200, 9600, 14400, 19200, 28800, 38400, 57600 and 115200. test_mcr()+ +Rationale: + +Comments: + +Covers: + - `XenProd~emul_ns16x50~1` + +Access Modem Control Register +----------------------------- + +`XenSwdgn~emul_ns16x50_mcr~1` + +Description: +Xen shall emulate a modem control register for read/write. test_fcr_toggle()+ +Rationale: + +Comments: + +Covers: + - `XenProd~emul_ns16x50~1` + +Enable and disable the FIFOs +---------------------------- + +`XenSwdgn~emul_ns16x50_fcr_enable~1` + +Description: +Xen shall report the FIFO state in the interrupt identification register +according to the FIFO enable bit of the FIFO control register. test_fcr_trigger()+ +Rationale: + +Comments: + +Covers: + - `XenProd~emul_ns16x50~1` + +Select the receiver FIFO trigger level +-------------------------------------- + +`XenSwdgn~emul_ns16x50_fcr_trigger_level~1` + +Description: +Xen shall accept a write of any receiver FIFO trigger level to the FIFO +control register. test_fcr_clear()+ +Rationale: + +Comments: + +Covers: + - `XenProd~emul_ns16x50~1` + +Clear the FIFOs +--------------- + +`XenSwdgn~emul_ns16x50_fcr_clear~1` + +Description: +Xen shall discard the buffered data of the receiver and the transmitter FIFOs +when the corresponding clear bit of the FIFO control register is written. test_loopback_data_path()+ +Rationale: + +Comments: + +Covers: + - `XenProd~emul_ns16x50~1` + +Transfer data in loopback mode +------------------------------ + +`XenSwdgn~emul_ns16x50_loopback_data~1` + +Description: +Xen shall route a byte written to the transmit holding register back to the +receiver buffer register when the loopback bit of the modem control register +is set. test_loopback_modem_path()+ +Rationale: + +Comments: + +Covers: + - `XenProd~emul_ns16x50~1` + +Report modem status in loopback mode +------------------------------------ + +`XenSwdgn~emul_ns16x50_loopback_modem~1` + +Description: +Xen shall reflect the modem control register outputs into the modem status +register inputs when the loopback bit of the modem control register is set. test_iir_noint()+ +Rationale: + +Comments: + +Covers: + - `XenProd~emul_ns16x50~1` + +Report no pending interrupt +--------------------------- + +`XenSwdgn~emul_ns16x50_iir_no_interrupt~1` + +Description: +Xen shall report no pending interrupt in the interrupt identification register +when no interrupt reason is enabled in the interrupt enable register. test_iir_thr_source()+ +Rationale: + +Comments: + +Covers: + - `XenProd~emul_ns16x50~1` + +Report the transmit holding register empty interrupt reason +----------------------------------------------------------- + +`XenSwdgn~emul_ns16x50_iir_thr~1` + +Description: +Xen shall report the transmit holding register empty interrupt reason in the +interrupt identification register while that reason is enabled and the +transmit holding register is empty. test_iir_rda_source()+ +Rationale: + +Comments: + +Covers: + - `XenProd~emul_ns16x50~1` + +Report the received data available interrupt reason +--------------------------------------------------- + +`XenSwdgn~emul_ns16x50_iir_rda~1` + +Description: +Xen shall report the received data available interrupt reason in the interrupt +identification register while that reason is enabled and unread data is +pending in the receiver. test_iir_priority()+ +Rationale: + +Comments: + +Covers: + - `XenProd~emul_ns16x50~1` + +Report the highest priority interrupt reason +-------------------------------------------- + +`XenSwdgn~emul_ns16x50_iir_priority~1` + +Description: +Xen shall report the highest priority pending interrupt reason in the +interrupt identification register when more than one enabled reason is +pending.
LGTM Reviewed-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx> - Ayan
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |