[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 0/3] x86: Add in-scope files under cpu/ to MISRA scans
- To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>
- Date: Thu, 19 Nov 2026 15:44:47 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6uMhTdlC3QVnr2qQ45yvtycEJmf4EIb/IIsiSruJI5g=; b=AU17HiW8laybYGk3B9lWT4y/VU8LY+3CPNQ/Bj4dSBjY06wSa9Qs2Swb39n72DOyS+uyiOdZIIs3Uv197dyKfXtLozqP4lhKcb54cIcDuE39bg+qlfZlGDHBD49m6GOMTOd1aK5MCJlDUczzLZajNUtX/enMgrG8oWE9xvoes56mir6JJ+9m3NqRYSfGxN7uU1yqJyLXrD73AArfYo+R+GLwKRjrHFsu2biWldYz3a2BVOwck/Iiw1go12Z2amTO3Z7+pl9L2pyw/TFEYppxaJyOfUjx7iBDJsbp/vdaFJpmC9XAj3YQ4mJ7/y4TkmBQHXsGJMCu/0ST1fv1if2QCg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=i5FLnmDUFNwnvBlq/Nj2JV5lqk09Swou6TUOZvMA+pz6/98xrUqSBJ0lKLzBNOiZYwr836LC7MlS64p7K3IaFzQX212jhz1xVCdGzqCBblIqad/ZRobPktXkYOaLeAQr3MEs6q5MHvyFsYjTORdEYdZFDsmgtfduXf9t7Jm0JG2l9bKOOh7V0s45x2yHw7KA0rrCW4pad9cpQ0j0a76u8/0c60f+ANwoiJmIxodm3cofZtYVQUE3L1ye3YFT80bA1ofEelD4BdinmhKPDSpOeqEGYU44AMLVBy2NcJNVun60Sza0fAo/b21QQTOq1gz9rGmpSd6SDM48eSQzyutK7w==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Cc: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>, Jason Andryuk <jason.andryuk@xxxxxxx>, "Nicola Vetrini" <nicola.vetrini@xxxxxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "Julien Grall" <julien@xxxxxxx>
- Delivery-date: Thu, 19 Nov 2026 14:45:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi,
v1:
https://lore.kernel.org/xen-devel/20261118171758.1125066-1-alejandro.garciavallejo@xxxxxxx/
pipeline:
https://gitlab.com/xen-project/people/agvallejo/xen/-/pipelines/3089539179
(slightly different. fpu.c has different macros, but functionally identical)
v2:
I've reworked the cpu_has_amd_erratum() function into small helpers and
brought the 383 erratum in line with Linux. It turns out a mistake was
made when merging it originally. OSVW is gone and bloat-o-meter reports
200 bytes of net code reduction.
Original cover letter:
The files under cpu/ are excluded from MISRA scans due to their Linux
provenance but they aren't kept in close sync. At best they get
semiregular updates (mwait_idle.c), but most often the files grow with
Xen specifics bops that get a free pass on MISRA scans merely due to
colocation with ancient Linux code. Some files just were never part of
Linux (hygon.c) to begin with, which makes the blanket exclusion even
less credible.
This series brings everything under the MISRA scan umbrella, with the
surprisingly few fixes involved.
Alejandro Vallejo (3):
x86/amd: Consider only Fam10h affected by erratum 383
x86/amd: Drop cpu_has_amd_erratum()
eclair/x86: Scan in-scope files inside cpu/
.../eclair_analysis/ECLAIR/deviations.ecl | 3 -
docs/misra/exclude-list.json | 36 -----------
xen/arch/x86/cpu/amd.c | 47 +-------------
xen/arch/x86/domain.c | 2 +-
xen/arch/x86/hvm/svm/asid.c | 2 +-
xen/arch/x86/hvm/svm/svm.c | 2 +-
xen/arch/x86/include/asm/amd.h | 62 ++++++-------------
xen/arch/x86/x86_emulate/fpu.c | 7 +--
xen/arch/x86/x86_emulate/x86_emulate.c | 5 --
9 files changed, 27 insertions(+), 139 deletions(-)
base-commit: 92ddcda17fb00020c6215d51df4c6a25d5eb0b5e
--
2.43.0
|