[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/p2m: prevent replacing special p2m entries


  • To: Roger Pau Monne <roger@xxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 19 Nov 2026 13:55:51 +0100
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID"
  • Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 19 Nov 2026 12:56:00 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 18.11.2026 18:20, Roger Pau Monne wrote:
> The current logic in both p2m_add_foreign() and xenmem_add_to_physmap_one()
> allows replacing special p2m types, that should otherwise only be
> established/cleaned up via special accessors.
> 
> When the backing page for a foreign p2m-type mapping only has one reference
> left, the put_page() in p2m_entry_modify() will free the page ahead of it
> being flushed from the p2m and the IOMMU TLBs.  This can be triggered with
> IOREQ servers, and requires a domain that has privileges over another one
> (ie: a stubdom).  Such a domain would create an IOREQ server, map it using
> XENMEM_acquire_resource (which creates a p2m_map_foreign p2m entry),
> destroy the IOREQ server, and afterwards map something over the IOREQ
> entries using XENMEM_add_to_physmap{,_batch}.  At this point the removal
> from the p2m will trigger an assert in p2m_entry_modify() on debug builds,
> or in releases < 4.22 free the page before the TLBs are flushed.
> 
> Something similar can also happen with grant mppaings: entries being

Nit: mappings

> replaced using p2m_add_foreign() or xenmem_add_to_physmap_one() will then
> fail when attempting to be cleaned up by replace_grant_host_mapping().
> However that only affects the domain itself, and is no worse than what a
> grant-mapping domain can already do to the grant source.
> 
> Note that p2m_add_page() already refuses to replace p2m entries of special
> types.
> 
> Fixes: b37d30c8fc52 ("Mapping grant references into HVM guests, take 2")
> Fixes: 0537d246f8db ("mm: add 'is_special_page' inline function")
> Signed-off-by: Roger Pau Monné <roger@xxxxxxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

However, I thought we had agreed that ...

> --- a/xen/arch/x86/mm/p2m.c
> +++ b/xen/arch/x86/mm/p2m.c
> @@ -1953,6 +1953,13 @@ static int p2m_add_foreign(struct domain *tdom, 
> unsigned long fgfn,
>  
>      /* Remove previously mapped page if it is present. */
>      prev_mfn = get_gfn(tdom, gpfn, &p2mt_prev);
> +    /* Special p2m slots must be cleaned up via special accessors. */
> +    if ( p2m_is_special(p2mt_prev) )
> +    {
> +        rc = -EPERM;
> +        goto put_both;
> +    }

... in particular this change comes with a (hopefully small) risk of breaking
existing code which maps one foreign page over a prior such mapping (never
torn down properly). And that you'd mention this aspect in the commit message.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.