[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 2/3] x86/nestedsvm: honour L2's EFLAGS.IF when L1 clears V_INTR_MASKING


  • To: chunjie.zhu@xxxxxxxxxx
  • From: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
  • Date: Thu, 19 Nov 2026 11:56:33 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EPV/vmw3CQtGfvJd9yPbqGHOkLK46fhGFNYGElTInx0=; b=NMp3OYcb8OPTWSfTfmyuOFMYd86Ei/+0eZA8x1bPb8dvizXyVJPGwCSmA1R5jyQOMVrZrnPYWRM4FZwZUmlDDI3sn8u6TUpMxQ0TMYG6kXvPx4gAmWHWOlgv3O6g5mygni7u947YNLL/H9ClTykz6+p9V78viOyp6OBW9nGMe0CBuMtTSs5gLmChzynDjIVmWriJuJvDV5PoiIJQD05r3cg8Volf9cGo4LUca7OR8v6YpXt7ZpAvQAzFXMKRODjRLd7Lh7kmfhwt02VG3JpYJ0YZrddeovEi/jE+MxkVWGU0GVofW8Rz5Zec06UX7Q8vjkwYEuo2ZqRMN3WqIbluig==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BuyKh6m2I6x1ezM29iUbr9biAkGunjQN7F8M6t0dJ3tBaEix9wr1Tt6CHXov8pllauhMpnm2G22Mp8kCNYoe/q7OCDBSdMEoX3R3H9EyhsMPeynbFuIRUt4/eSBw4AZkA1MPDaTrUKdSGAo+npwBPg1034OwE3Da3Hauoo9z/MspV1d0VUD7Q5mrFcFfMY5fRX/cGTeMsiHmEyW96hSWp8XzN4a8u2cOnTQfnvuvUtAdXPoyaavHek+oOoa0BFXtNaBq523NJWYdvf3m63dIzaBPYmSuUh3gSNdvesA2FUN22xoq58rlVFYJB4OepIGQzgAyUa7+0GrQLBjUkSL9NA==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: andrew.cooper3@xxxxxxxxxx, jason.andryuk@xxxxxxx, jbeulich@xxxxxxxx, roger@xxxxxxxxxxxxxx, teddy.astie@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 19 Nov 2026 11:56:43 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 11/12/26 11:35 AM, chunjie.zhu@xxxxxxxxxx wrote:
From: Chunjie Zhu <chunjie.zhu@xxxxxxxxxx>

L0 always runs L2 with V_INTR_MASKING set, so a physical interrupt exits to
L0 regardless of L2's EFLAGS.IF.  nsvm_intr_blocked() only blocks when L1
requested V_INTR_MASKING=1 and L1's IF was clear.  With V_INTR_MASKING=0
and L2's IF clear, nestedsvm_vcpu_interrupt() would still inject
VMEXIT(INTR) into L1.

Per the APM (vol.2 rev 3.44 "Physical Interrupt Masking in EFLAGS"), with
V_INTR_MASKING=0 L2's IF masks physical interrupts, and a masked interrupt
must stay pending.  Return NSVM_INTR_MASKED for external interrupts in
that case.

Signed-off-by: Chunjie Zhu <chunjie.zhu@xxxxxxxxxx>

I think this should be:

Fixes: 3a1ef3c33fa7 ("Implement SVM specific interrupt handling")

With that,
Reviewed-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.