[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/4] xen/arm: guest_walk: refuse a block descriptor where the granule has none
- To: Stefano Stabellini <stefano.stabellini@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Thu, 19 Nov 2026 08:14:48 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N0rqx1/XhVI0bpv0Oeo2nZJn/orGMH9SvJOSl51ewmg=; b=LeSSkBzZNCj7eHFlcPu1ZduiecsuL/Efw+99f8KV9uuuTLhijVQWxPemyBkb/+N93ON3LRycW14mZerC5BFZA3ccdojN/+UiKhaTCfw11bT8+tMlRJE4/uPDGua9wEra3cRTD8AWlWNrwA4rq/8i+1ID1to5jeJCfdXb2mR49RGl00QfsrYLQXYhePdex5+UogafyW/AEnvtJGDiDcnDv4/Bf+owWhLPOdfuH4n0aH5hNfenTXmY24V+DfKih9CBpAIQTnV43S3r8SUpEhqqPH47liAGbaixcLBRlCYQfWCwp5jGc8Xfr4LBVgq5U1hX5wcscoMfWLYQeilYIc47UQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wJhq0qg/sCM/vtQnsxHBS94c7HVB4NqzXmXyzRhkenxCnOwhR9rEMj4kJlNVKBdR1efZMeuJGQ88kZaRnkXjY3qIjKTPyAREciU4eKunCEO4HO+av0/q5ryscu0DcgRn38P7uC779T9mM9eUdfrFm1xzSxpm05sWTrHZcT+eSnG5a048RPHenh1vH2enee1CpDzI0nMxxeJ3EhuddOfKxqTiDKNyRXbqQYH+MD9AAeTFHlihzogAUvv53IBhTJXjwse5HJ5YogqKKnFP6DD3S2kidKSRPpdpkWooj4VTSFMJY/wpxkfG3w+ty0EHMqOAqLneqfinVhBC2pbwBYcWeg==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Cc: Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 19 Nov 2026 07:15:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18-Nov-26 01:59, Stefano Stabellini wrote:
> guest_walk_ld() accepted a block descriptor at any level. No granule has
> level 0 blocks, and the 16KB and 64KB granules have no level 1 blocks
> (ARM DDI 0487 M.d D8.3.1.2): the translation table walk makes such an
> entry a Translation fault (AArch64.BlockDescSupported()). Refuse it.
>
> The check is only valid without 52-bit support (FEAT_LPA, FEAT_LPA2).
> Note in get_ipa_output_size() that 52-bit support requires updating it.
>
> Fixes: 7d623b358a45 ("arm/mem_access: Add long-descriptor based gpt")
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|