[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] arm/smmuv3: clean stream tables for non-coherent hardware


  • To: Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>
  • From: Mykola Kvach <xakep.amatop@xxxxxxxxx>
  • Date: Thu, 19 Nov 2026 01:58:00 +0200
  • Arc-authentication-results: i=1; mx.google.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=dpk01LpU9o5gNpQSc9W4v8M8KHGqOxd5JMynkBNQM0w=; fh=9tGvDWADeoMzXRnBQW23sIg7lwe9F2kmlJLTwTbhM0Y=; b=AHmRtDMWEdMpbQEfv1Cp9LHgrszuM1qn1IZDwBuFwpKRQzAPsG0shgLOyn3/K2gb4H pIKOtxEPHMqg3dLHmVoLA6OojlVl/XO7NEgCaFRDp9MOpayniNP345N1a9cJpxp1R6bb uaQ7XLVMQgjgbqCLX1q57FHac9hnzEZ45vGxiJjKhhsNLWKN61gLX/xCgEpnoiTv4B3s rwFA3s52tIBI1ucTV78ZgRRq/hc8URxqt7jone6K1nhv4Tnfry5ATXfor6mnAz5XavRZ bu5KJ8+77N3uMnAoOLc8RtHn0sNhwi6a/PzamKpH2GZ5fNIO5GkTjEgkPcnnhte7l2Dc O2+A==; darn=lists.xenproject.org
  • Arc-seal: i=1; a=rsa-sha256; t=1795046292; cv=none; d=google.com; s=arc-20260327; b=a75nWYDvpr4nrMG0qKoAdKa3PY0Ia3QersHBNwZGWoUrsBgzCzKehO7OKypFnXIOtd MR/7IRBy6z3Jt0gsiHWE9iUMpZvUKIeOcoFQmvQTAIngv7m32boTJGVQ9e/8cfo1LvFa RjQtG630E+LAbeDP16XH+uPJH1My/V7IDhFBlIeLhGnK5h26NmyJ0dtkXD0UbQQCVhlf E/uUpAh+xKgDC9tbLiRPZcLeE7kiCLXfxAiElFIAztW5BxFWiFarmHa0kTfPqhc2KlM+ 3PbD1488BZZmV7UozynXH5qN5nWqxpUxldHJP1b/mntKTq+IDV1JEWKnpt+eM3qaxyI1 BYEA==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20260707 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version"
  • Cc: Mykola Kvach <Mykola_Kvach@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Wed, 18 Nov 2026 23:58:21 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hi Oleksandr,

On Wed, Nov 18, 2026 at 11:04 PM Oleksandr Tyshchenko
<olekstysh@xxxxxxxxx> wrote:
>
>
>
> 16.11.2026 13:47, Mykola Kvach пишет:
>
> Hello Mykola
>
>
> > Xen's dmam_alloc_coherent() returns cacheable memory. A non-coherent
> > SMMU cannot see writes that remain in the CPU cache.
> >
> > On Orange Pi 5 (RK3588S), NVMe initialization failed with C_BAD_STREAMID
> > for SID 0x4100 while the CPU saw a populated L1 descriptor.
> >
> > Clean new stream tables before use. Clean updated STE data in
> > arm_smmu_sync_ste_for_sid() before issuing CFGI_STE and CMD_SYNC.
> > Keep both sync points around the dst[0] update.
> >
> > Clean the L2 table before writing its L1 pointer, then clean the pointer.
> > Skip these cache operations on coherent SMMUs.
> >
> > See Arm IHI 0070G.b, sections 3.15 and 3.21.3.1.
> >
> > Fixes: 452ddbe3592b ("xen/arm: smmuv3: Add support for SMMUv3 driver")
> > Assisted-by: Codex:GPT-6.1
> > Signed-off-by: Mykola Kvach <mykola_kvach@xxxxxxxx>
>
>
> So, If I understand the patch/problem correctly, this looks like a
> follow-up to "xen/arm: smmuv3: Add cache maintenance for non-coherent
> SMMU queues". The underlying issue seems the same, cache maintenance for
> in-memory data structures, except that previous patch addressed the
> command queue, while this one targets the stream table.

Thanks for the review. Yes, the earlier patch fixed the same cache
visibility issue for the queues. This patch covers the stream tables.

>
> I did not find any serious issues with the current patch, just a couple
> of NITs below for you to consider.
>
> Preferably with the NITs addressed:
> Reviewed-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
>
> > ---
> > Changes in v2:
> > - Rename arm_smmu_clean_strtab() to arm_smmu_clean_dcache().
> > - Pass the STE pointer and clean size to arm_smmu_sync_ste_for_sid().
> >    Clean the given range there before CFGI_STE and CMD_SYNC. Keep the
> >    original clean ranges, both sync points around dst[0], and the
> >    explicit cleaning during table initialisation.
> > ---
> >   xen/drivers/passthrough/arm/smmu-v3.c | 27 +++++++++++++++++++++++----
> >   1 file changed, 23 insertions(+), 4 deletions(-)
> >
> > diff --git a/xen/drivers/passthrough/arm/smmu-v3.c 
> > b/xen/drivers/passthrough/arm/smmu-v3.c
> > index 232df2421c..945a18a7a1 100644
> > --- a/xen/drivers/passthrough/arm/smmu-v3.c
> > +++ b/xen/drivers/passthrough/arm/smmu-v3.c
> > @@ -637,6 +637,14 @@ static int arm_smmu_cmdq_issue_sync(struct 
> > arm_smmu_device *smmu)
> >   }
> >
> >   /* Stream table manipulation functions */
> > +static void arm_smmu_clean_dcache(struct arm_smmu_device *smmu,
> > +                             const void *ptr, size_t size)
> > +{
> > +     /* Xen's dmam_alloc_coherent() returns cacheable memory. */
> > +     if (!(smmu->features & ARM_SMMU_FEAT_COHERENCY))
> > +             (void)clean_dcache_va_range(ptr, size);
>
> So, two ways of testing coherency in one file. The queues use
> q->non_coherent in several places. The new helper reads smmu->features &
> ARM_SMMU_FEAT_COHERENCY. Both derive from the same bit, so behaviour is
> correct.
>
> NIT 1: Cast is inconsistent. The helper casts the int return of
> clean_dcache_va_range() to (void). The queue code in the same file
> ignores the same return without a cast.

On Arm, clean_dcache_va_range() always returns 0. I used (void) in
the new helper to discard the result explicitly and avoid a new
MISRA C Rule 17.7 violation. I kept the patch focused on the
stream-table code.

>
> NIT 2: I wonder if the queue code's open-coded "if (q->non_coherent)
> clean/invalidate..." calls could share the helper? That would eliminate
> the duplicate coherency checks, avoid spreading CMO logic across the
> driver, and also resolve NIT 1 since the cast (or lack thereof) would
> live in one place.

I see the benefit of sharing the cache helpers. I'd prefer to keep
this patch focused on the stream-table fix.

The queue functions already get the same coherency information from
q->non_coherent, so sharing the helpers there could be a separate
refactoring. I'd also welcome the maintainers' thoughts on whether
it makes sense to include that change in this patch.

>
> ***
>
> Somthing like this:
> +static void arm_smmu_clean_dcache(struct arm_smmu_device *smmu,
> +                                 const void *ptr, size_t size)
> +{
> +       if (!(smmu->features & ARM_SMMU_FEAT_COHERENCY))
> +               (void)clean_dcache_va_range(ptr, size);
> +}
> +
> +static void arm_smmu_invalidate_dcache(struct arm_smmu_device *smmu,
> +                                      const void *ptr, size_t size)
> +{
> +       if (!(smmu->features & ARM_SMMU_FEAT_COHERENCY))
> +               (void)invalidate_dcache_va_range(ptr, size);
> +}
>
>
> The queue callers would then look like this:
>
> -       if (q->non_coherent)
> -               clean_dcache_va_range(q_addr, q->ent_dwords * 
> sizeof(*q_addr));
> +       arm_smmu_clean_dcache(q->smmu, q_addr,
> +                             q->ent_dwords * sizeof(*q_addr));
>
> ...
>
> -       if (q->non_coherent)
> -               invalidate_dcache_va_range(q_addr, q->ent_dwords * 
> sizeof(*q_addr));
> +       arm_smmu_invalidate_dcache(q->smmu, q_addr,
> +                                  q->ent_dwords * sizeof(*q_addr));
>
> For this to work, the queue needs a back pointer to the SMMU
> (replacing the non_coherent flag), set in arm_smmu_init_one_queue():
>
> -       q->non_coherent = !(smmu->features & ARM_SMMU_FEAT_COHERENCY);
> +       q->smmu = smmu;
>
>
> struct arm_smmu_queue {
>          ...
>
> -       /* Is the memory access coherent? */
> -       bool                            non_coherent;
> +       struct arm_smmu_device          *smmu;
>   };
>
> This is optional, so feel free to keep the code as it is if you prefer.
>
>
> > +}
> > +
> >   static void
> >   arm_smmu_write_strtab_l1_desc(__le64 *dst, struct arm_smmu_strtab_l1_desc 
> > *desc)
> >   {
> > @@ -649,7 +657,8 @@ arm_smmu_write_strtab_l1_desc(__le64 *dst, struct 
> > arm_smmu_strtab_l1_desc *desc)
> >       write_atomic(dst, cpu_to_le64(val));
> >   }
> >
> > -static void arm_smmu_sync_ste_for_sid(struct arm_smmu_device *smmu, u32 
> > sid)
> > +static void arm_smmu_sync_ste_for_sid(struct arm_smmu_device *smmu, u32 
> > sid,
> > +                                   const __le64 *dst, size_t size)
> >   {
> >       struct arm_smmu_cmdq_ent cmd = {
> >               .opcode = CMDQ_OP_CFGI_STE,
> > @@ -659,6 +668,7 @@ static void arm_smmu_sync_ste_for_sid(struct 
> > arm_smmu_device *smmu, u32 sid)
> >               },
> >       };
> >
> > +     arm_smmu_clean_dcache(smmu, dst, size);
> >       arm_smmu_cmdq_issue_cmd(smmu, &cmd);
> >       arm_smmu_cmdq_issue_sync(smmu);
> >   }
> > @@ -736,7 +746,8 @@ static void arm_smmu_write_strtab_ent(struct 
> > arm_smmu_master *master, u32 sid,
> >                * the STE regardless of whether the old value was live.
> >                */
> >               if (smmu)
> > -                     arm_smmu_sync_ste_for_sid(smmu, sid);
> > +                     arm_smmu_sync_ste_for_sid(smmu, sid, dst,
> > +                                               STRTAB_STE_DWORDS << 3);
> >               return;
> >       }
> >
> > @@ -762,9 +773,9 @@ static void arm_smmu_write_strtab_ent(struct 
> > arm_smmu_master *master, u32 sid,
> >               dst[1] |= cpu_to_le64(FIELD_PREP(STRTAB_STE_1_EATS,
> >                                                STRTAB_STE_1_EATS_TRANS));
> >
> > -     arm_smmu_sync_ste_for_sid(smmu, sid);
> > +     arm_smmu_sync_ste_for_sid(smmu, sid, dst, STRTAB_STE_DWORDS << 3);
> >       write_atomic(&dst[0], cpu_to_le64(val));
> > -     arm_smmu_sync_ste_for_sid(smmu, sid);
> > +     arm_smmu_sync_ste_for_sid(smmu, sid, dst, sizeof(*dst));
> >
> >       /* It's likely that we'll want to use the new STE soon */
> >       if (!(smmu->options & ARM_SMMU_OPT_SKIP_PREFETCH))
> > @@ -805,7 +816,10 @@ static int arm_smmu_init_l2_strtab(struct 
> > arm_smmu_device *smmu, u32 sid)
> >       }
> >
> >       arm_smmu_init_bypass_stes(desc->l2ptr, 1 << STRTAB_SPLIT);
> > +     /* Clean the L2 table before writing the L1 pointer. */
> > +     arm_smmu_clean_dcache(smmu, desc->l2ptr, size);
> >       arm_smmu_write_strtab_l1_desc(strtab, desc);
> > +     arm_smmu_clean_dcache(smmu, strtab, STRTAB_L1_DESC_DWORDS << 3);
> >       return 0;
> >   }
> >
> > @@ -1744,6 +1758,7 @@ static int __init arm_smmu_init_queues(struct 
> > arm_smmu_device *smmu)
> >   static int arm_smmu_init_l1_strtab(struct arm_smmu_device *smmu)
> >   {
> >       unsigned int i;
> > +     size_t size;
> >       struct arm_smmu_strtab_cfg *cfg = &smmu->strtab_cfg;
> >       void *strtab = smmu->strtab_cfg.strtab;
> >
> > @@ -1757,6 +1772,9 @@ static int arm_smmu_init_l1_strtab(struct 
> > arm_smmu_device *smmu)
> >               strtab += STRTAB_L1_DESC_DWORDS << 3;
> >       }
> >
> > +     size = cfg->num_l1_ents * (STRTAB_L1_DESC_DWORDS << 3);
> > +     arm_smmu_clean_dcache(smmu, cfg->strtab, size);
>
> NIT 3: arm_smmu_init_l1_strtab() recomputes the L1 size that its caller
> already has as l1size. I would move arm_smmu_clean_dcache() to
> arm_smmu_init_strtab_2lvl() to avoid recalculating it and reduce the diff.

Agreed. I'll move the L1 table clean to arm_smmu_init_strtab_2lvl()
and use the existing l1size once arm_smmu_init_l1_strtab() succeeds.

Best regards,
Mykola



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.