[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 08/28] x86/hvm: avic: add AVIC_INCOMP_IPI VMEXIT handler


  • To: dmukhin@xxxxxxxx
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 18 Nov 2026 16:33:45 +0100
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID"
  • Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
  • Cc: andrew.cooper3@xxxxxxxxxx, jason.andryuk@xxxxxxx, roger@xxxxxxxxxxxxxx, teddy.astie@xxxxxxxxxx, dmukhin@xxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 18 Nov 2026 15:33:58 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 05.11.2026 02:33, dmukhin@xxxxxxxx wrote:
> @@ -235,6 +236,120 @@ void svm_avic_vmcb_destroy(struct vcpu *v)
>      vmcb->avic_vapic_bar = 0;
>  }
>  
> +/*
> + * Handle the AVIC_INCOMP_IPI #VMEXIT when AVIC is enabled.
> + *
> + * The hardware generates this fault when an IPI could not be delivered to
> + * all targeted guest virtual processors because at least one guest virtual
> + * processor was not allocated to a physical core at the time.
> + */
> +void svm_avic_vmexit_incomp_ipi(struct cpu_user_regs *regs)
> +{
> +    struct vcpu *v = current;
> +    struct domain *d = v->domain;
> +    struct svm_vcpu *sv = &v->arch.hvm.svm;
> +    const struct vmcb_struct *vmcb = sv->vmcb;
> +    uint32_t icrh = vmcb->exitinfo1 >> 32;
> +    uint32_t icrl = vmcb->exitinfo1;
> +    uint32_t id = vmcb->exitinfo2 >> 32;
> +    uint32_t index = vmcb->exitinfo2 & 0x1FFU;

0x1ffU please, to have the U better stand out.

> +    if ( id >= AVIC_IPI_FAILURE_MAX )
> +    {
> +        domain_crash(
> +            d, "%pv: AVIC: Unknown IPI interception (exitinfo1=%#"PRIx64" 
> exitinfo2=%#"PRIx64")\n",
> +            v, vmcb->exitinfo1, vmcb->exitinfo2);
> +        return;
> +    }

Why can this code not live in the default: case further down?

> +    BUG_ON(sv->avic_physical_id == NULL);
> +
> +    switch ( id )
> +    {
> +    case AVIC_IPI_FAILURE_INVALID_INT_TYPE:
> +        /*
> +         * AVIC hardware handles the delivery of IPIs when the specified
> +         * Message Type is Fixed (also known as fixed delivery mode) and the
> +         * Trigger Mode is edge-triggered. The hardware also supports self 
> and
> +         * broadcast delivery modes specified via the Destination
> +         * Shorthand(DSH) field of the ICRL. Logical and physical APIC ID
> +         * formats are supported. All other IPI types cause a #VMEXIT, which
> +         * needs to emulated.
> +         */
> +        gprintk(XENLOG_ERR,
> +                "%pv: AVIC: Invalid IPI type (icr=%#08x:%08x, idx=%u)"
> +                " avic_physical_id=%#"PRIx64"\n",
> +                v, icrh, icrl, index, ACCESS_ONCE(*sv->avic_physical_id));
> +
> +        vlapic_reg_write(v, APIC_ICR2, icrh);
> +        vlapic_reg_write(v, APIC_ICR,  icrl);

Is this legitimate in x2APIC mode? Also, if this is what you introduce
vlapic_reg_write() for, wouldn't this better be a dedicated ICR writing
helper anyway?

> --- a/xen/arch/x86/hvm/svm/vmcb.h
> +++ b/xen/arch/x86/hvm/svm/vmcb.h
> @@ -291,6 +291,13 @@ enum VMEXIT_EXITCODE
>      VMEXIT_BUS_LOCK         = 165, /* 0xa5 */
>      /* Remember to also update VMEXIT_NPF_PERFC! */
>      VMEXIT_NPF              = 1024, /* 0x400, nested paging fault */
> +
> +    /*
> +     * AMD64 Architecture Programmer's Manual Volume 2: System Programming
> +     * Table 15-22. Guest vAPIC Register Access Behavior
> +     */
> +    VMEXIT_AVIC_INCOMP_IPI  = 1025, /* 0x401 */
> +
>      /* Remember to also update SVM_PERF_EXIT_REASON_SIZE! */
>      VMEXIT_INVALID          =  -1

Please pay attention to the pre-existing comments here.

> --- a/xen/arch/x86/include/asm/hvm/svm-types.h
> +++ b/xen/arch/x86/include/asm/hvm/svm-types.h
> @@ -25,6 +25,16 @@ struct svm_domain {
>      uint64_t *avic_physical_id_table;
>  };
>  
> +/* AVIC_INCOMP_IPI #VMEXIT reason. */
> +enum avic_ipi_failure_cause {
> +    AVIC_IPI_FAILURE_INVALID_INT_TYPE       = 0,
> +    AVIC_IPI_FAILURE_TARGET_NOT_RUNNING     = 1,
> +    AVIC_IPI_FAILURE_INVALID_TARGET         = 2,
> +    AVIC_IPI_FAILURE_INVALID_BACKING_PAGE   = 3,
> +    AVIC_IPI_FAILURE_INVALID_IPI_VECTOR     = 4,
> +    AVIC_IPI_FAILURE_MAX,

As per the comment towards the top, this last one shouldn't be needed
(or else it's mis-named). I also don't see why for the others explicit
values would need assigning.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.