[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] ELF/notes: use pointer-to-const by default in ELFNOTE_...()


  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx>
  • Date: Wed, 18 Nov 2026 15:37:12 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4UOspVItX6hnOTH+ycJoyjfNmWfrROiwkirRsmfw7Z0=; b=RYXY6TSaQr+vgMGsAUZACx6xV0BKXhGOj/ajQtngTAYlDZ/q/KAsr5QmifIZDoeZknZEh/KiwmIU6GRsz4GKmCvhSlyVj5tCtt+XH1kNJAYK1CQGF/1ooKN6WvHVwE230UHnitSmKW3SdBuqsVJFxrYxvzCi7DnJIWZbIdOgnoRFSGDEv0vOq1wFuT7x9KatWodiGK65rMH9rl5/f6COmwXoh4gJ34ntrSFI6jzx8STi+X1yVbrkBFkmKypjQpkzNdOq0DrAa0XXO+wYsxxuSwxGPZUaVIHE64W8wl4JwTOffdSi0apDGI/oUliDy4qPMIcPXlv/mKZziEjuySj0Zw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=J4FCyMLEnTxnoXdK2TQnjqqOVPXIfpvnvT3QEKFDgHeVSs5vT3mJfTWwR0aLoL2iqVYzxSD311OVPVnNPHzzSHwbOExw2DkOTRzQhp1XqDZ96Z2Ydvaya5DZgcnh/k03faM4gFA7NWdrpAAojXEMd7rteGCz5Nql2fOOd38DJcR6juUCBbPOwtAQkdzwOEXpVXkLQmXtGSOv3619gYnXHnqqMQTGjyKW9akR8g72xyZ3TqdfUAZeWnkD3d45dY5PR0r4/HGvLQoVC5RBlMMXCafaJcUq23SCTA9stfUQy1X9nP0SGTjsFpp1XId/rEgNXRKjuHWD/fC7iukrYjm7Ig==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=epam.com header.i="@epam.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Wed, 18 Nov 2026 13:37:23 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>



On 11/18/26 10:24, Jan Beulich wrote:
Not doing so results in a number of Misra rule 11.8 (casting away of
const-ness) violations. We need to allow kexec to use pointer to non-
const though, so provide a means to override the default.

For ELFNOTE_NEXT() we can do better and simply re-apply the type of the
incoming pointer.

No functional change intended.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
---
v2: Use ELFNOTE_NO_CONST as the external control identifier.

Reviewed-by: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx>


--- a/xen/common/kexec.c
+++ b/xen/common/kexec.c
@@ -6,6 +6,9 @@
   * - Magnus Damm <magnus@xxxxxxxxxxxxx>
   */
+/* We're producing ELF notes here. */
+#define ELFNOTE_NO_CONST
+
  #include <xen/acpi.h>
  #include <xen/console.h>
  #include <xen/cpu.h>
--- a/xen/include/xen/elf.h
+++ b/xen/include/xen/elf.h
@@ -29,9 +29,16 @@
#include <xen/elfstructs.h> +#ifndef ELFNOTE_NO_CONST
+#define ELFNOTE_CONST const
+#else
+#define ELFNOTE_CONST
+#endif
+
  #define ELFNOTE_ALIGN(_n_) (((_n_)+3)&~3)
-#define ELFNOTE_NAME(_n_) ((char*)(_n_) + sizeof(*(_n_)))
+#define ELFNOTE_NAME(_n_) ((ELFNOTE_CONST char *)(_n_) + sizeof(*(_n_)))
  #define ELFNOTE_DESC(_n_) (ELFNOTE_NAME(_n_) + ELFNOTE_ALIGN((_n_)->namesz))
-#define ELFNOTE_NEXT(_n_) ((Elf_Note *)(ELFNOTE_DESC(_n_) + 
ELFNOTE_ALIGN((_n_)->descsz)))
+#define ELFNOTE_NEXT(_n_) ((typeof(_n_))(ELFNOTE_DESC(_n_) + \
+                                         ELFNOTE_ALIGN((_n_)->descsz)))
#endif /* __XEN_ELF_H__ */

BR, Dmytro.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.