[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/2] xen/build-id: Drop xen_build_id_check()
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
- Date: Wed, 18 Nov 2026 11:56:33 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ADPG7ChlkpL0JVHpf5FBFe3m++Rkt8bWY2RbzHUvrRQ=; b=zEzFMNhX+QGWCwRE70eR0Cg5TSKd4ndW2u/KCm9WTZpSLaQQ8jYcqw47IlkZXBb3PT9TfzZHNZoroPf76WllAhVUg3o6/gYT6alsfenbiAgcy9hZfxK5PwOi/Zq+9CwauPPkgGd9mYPgKsy41VmKgc2zFXknbhSTxqWU0U/axxHv1hGvC2C+Ey+YdkP2D/43ZwlPAehOs2piPQx4JIzL2d+hqzhLMSZHzzo/OThHNy2ZrzAZOlIfKCv4EJ3XSmPSxghardNosdBEMIS89maQe4EjYA6M8lkxOECSNYdBBQzt+sS7yRtRMUfw1raHT9ya7pqPsBdxTZaGtTOrwJ3Wow==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=S2kaoBi57dpGVExu5kQAdqBSSrY3VTxvcWGwzpS5KOxY1ZQUyY6swjYNUtZ4tILyFQw53qEwzo8k1N6vgSGkDaLrNxc8KZKvrsYPBJ/PjZhkyoSJ2S76c+yVfu8kc8TIpfgWV4tIgVrbvQCtAUmkTf5DAZOw+yI5EtW0tl1JpKegg8ZmssQekm2EC7UdEoj6kYZm5dcA8eb9vDXUTkn9Yda5V9Ufp0ZIqHMgZURwuOIS24SZjgLgNF1gn3CsMi2WvA5g3VbXe//XiT+u6vKUktf7WSZATs/b3HDdgshSsscbiYV4+nymbrWb1ldQEi/C0DXXh6cS73SGWtgLmgy4gg==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Wed, 18 Nov 2026 11:56:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11/17/26 8:22 PM, Andrew Cooper wrote:
The function is misnamed; it really is looking for a GNU Build ID note, not a
Xen note as the name suggests.
It also has an awkward API to use. For a GNU Build ID, the content is always
at +16 from the start, so really doesn't need to be returned by pointer, nor
is it necessary be doing additional checks on the returned pointers being
valid.
Switching to is_gnu_build_id() allows xen_build_init() to be simplified,
returning after the first successful find rather than passing an rc down the
function to skip later checks.
No functional change.
Reviewed-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
Thanks,
Ross
|