[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/2] xen/build-id: Introduce is_gnu_build_id()
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- From: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
- Date: Wed, 18 Nov 2026 11:53:23 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0kHR+0ATyqb9XefVDPeK+xybhnYCaFOdT86Z/0ACsv0=; b=IHdGMwkJ9gtt3PFQPoK0XRVaDCUIYCY7nIUGAZxV1hxekuPQNUpE/sh/+7HKgDq1JviNRI9XPaEZJ4OkgunalKGvrckQHF5JkrViAE2N37SqZ8hr6FlwhGRLK8/sO79k/fkcmTqquS6PpRS//7RuazvCvG/hn3xZxCcq8qRwgwrRHJUn8EAscLi1+eUkDlVoc+KsFP49kbU+XOOanzt5jASKWhRPSMnkiKObSu+JPbz89qriw8unl9VA/ZH54qorsz2EHomMn0I/3RJ1pMjyuEI1GhAUCxQMqjmS0ncIURsOiPWkBOewACRO24g/EYgs5suaolbTsOGt8F5mmm28bA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UWneE1HI2i3pfAP3LMmLDYpYI3g/tyZ72Dtj5XPXDTuUtKpkQmgnur4E+bdlkUU7MQ7NQOGt0tcqwKXva7XGueFT4CbTVOT6bCa/TlhETXrD7B6OYuEk3/OnXQMTzXnccUjtnHwL6/0mU8tLaXf3+HJcFap0LXTmdiR8p53TO0NwfT9uWzkKRCYOfCdhPQUiandw4+PgWML2azvQYCdyN4i7j2o1eRUAYYiuhMCJXh4wf1QZr6cmcM3hwyth16IJZqFVbz+3WpzLmfcIBAhoSTbgvuRndjRqB2eL9kcb8Ryi+tc70Ig4s4y0K+VWCqVGGoigjNAMY7u4dYND33EIsw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 18 Nov 2026 11:53:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11/18/26 10:51 AM, Andrew Cooper wrote:
On 18/11/2026 8:51 am, Jan Beulich wrote:
On 17.11.2026 21:22, Andrew Cooper wrote:
Broken out of the subsequent change for legibility reasons. It will be used
to replace xen_build_id_check().
Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Thanks, but it's just occurred to me that I need to make the logic:
if ( n->descsz == 0 ||
n->descsz > (len - NT_GNU_BUILD_ID) )
return false;
to retain the property of rejecting a zero-size note, now that descsz is
not strictly checked against a length that was confirmed to be 17 or more.
I'll fold this in on commit.
Shouldn't this be NT_GNU_HDR_SIZE, not NT_GNU_BUILD_ID?
With that change,
Reviewed-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
|