[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v2] x86emul: Zero-extend the XOP0A and MOV B8+r immediates when decoding


  • To: xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Stephen Cheng <stephen.cheng@xxxxxxxxxx>
  • Date: Wed, 18 Nov 2026 17:28:07 +0800
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QSf2Uvz5wcfplAARzuN3QqmviTq27gMBishNDsstmDk=; b=g0+6g1Zp+PiQKJBCjqpazwprrXkZGzBzbaUzerXHJ64+Ba0SGJfAKR1xZYcl45tZIHQgrg7q6NZNIo8Y+hiDw8i6Rsn49znDrTHz8lbMN9rSV42c4mlz4JhXCApbb6nV8+2fbSJiK72eGY4mxgIRXrYsEkieZXZD/BSPIwOkPxeFLCcWHLuH8WMce+On9iFP6gtT/Ck/iw9W9e9wjYgkZhcJ3VFhKJFmipIMFqw7AZVoC1J/83vQdq3YcYoi+FbqcafhBdhZeK/Ubrl+FornVtUrYbGxGg5GAP5YPQNbEgDjiIUD2beUrhdcCNtsHOR7TvxfMClbThGMZb2ndDWRHg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BqeM7XEDWQTzLTl/H5gmDs604jjLu+ExWUE3bozO+2NBdDVX4Gzee/QXq1UtRHoYsq8HTRl6V/GTVpL7dKzzGpsdfUXYh4Fd9P1vUJoY1F/lCkjEA8LKI6u/K83BZ8RfRQ92RU0JDYcemf5qk2xMBqVPbO5PYULNGtyxakWMezjctUaoBGrh4/ZI5LPtyCJnHfE659beqLQ/ywPUOB3a0hXGkv7SZA5IQelzx5aUZu8ULIbIB3YAogAgyPzsaqxKESNLwZqCghbhrYe2GCuRPalub3B26nh+bGMeBoEPQeqihPYp3ljMvCcm140R/lxclb1II+Tc4lWj8JFCY6QXAA==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>, Stephen Cheng <stephen.cheng@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>
  • Delivery-date: Wed, 18 Nov 2026 09:28:26 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

The decoder sign-extends the 32-bit immediate of the XOP0A insns
(BEXTR, LWPINS, LWPVAL), but this immediate is unsigned. It also
sign-extends the 32-bit immediate of MOV B8+r without REX.W, while with
REX.W the low half is already zero-extended to build the 64-bit
immediate. In 64-bit mode MOV r32,imm32 zero-extends into the full
register. Emulation uses only the low bits, so only
x86_insn_immediate() returns a wrong value. No current caller reads it
for these insns.

Zero-extend the XOP0A immediate, as commit aa6070d2c840 ("x86emul:
Zero-extend unsigned 8-bit immediates when decoding") did for the 0F,
0F3A and XOP08 maps. For MOV B8+r, zero-extend the 32-bit immediate,
and keep only the fetch of the high half in the REX.W path. The 16-bit
form is left alone, like the 8-bit form (B0+r) and other insns' 16-bit
immediates.

Fixes: 653cae725cea ("x86/32on64: use generic instruction decoding for call 
gate emulation")
Requested-by: Jan Beulich <jbeulich@xxxxxxxx>
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Stephen Cheng <stephen.cheng@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
---
v2:
 - Leave the 16-bit form of MOV B8+r alone, to be consistent with the
   8-bit form (B0+r) (Jan).
 - Keep Jan's R-b, as this is the option he preferred.

v1: 
https://lore.kernel.org/xen-devel/20261118085711.564158-1-stephen.cheng@xxxxxxxxxx/

 xen/arch/x86/x86_emulate/decode.c | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/xen/arch/x86/x86_emulate/decode.c 
b/xen/arch/x86/x86_emulate/decode.c
index 2bd2494272..d3a102df8c 100644
--- a/xen/arch/x86/x86_emulate/decode.c
+++ b/xen/arch/x86/x86_emulate/decode.c
@@ -683,9 +683,12 @@ decode_onebyte(struct x86_emulate_state *s,
         break;
 
     case 0xb8 ... 0xbf: /* mov imm{16,32,64},r{16,32,64} */
+        if ( s->op_bytes == 2 )
+            break;
+        /* Like the 32-bit register write, the immediate is zero-extended. */
+        s->imm1 &= 0xffffffffU;
         if ( s->op_bytes == 8 ) /* Fetch more bytes to obtain imm64. */
-            s->imm1 = ((uint32_t)s->imm1 |
-                       ((uint64_t)insn_fetch_type(uint32_t) << 32));
+            s->imm1 |= (uint64_t)insn_fetch_type(uint32_t) << 32;
         break;
 
     case 0xd4: /* aam */
@@ -1839,10 +1842,14 @@ int x86emul_decode(struct x86_emulate_state *s,
         s->simd_size = ext8f08_table[b].simd_size;
         break;
 
+    case ext_8f0a:
+        /* All immediates in this encoding space are unsigned ones. */
+        s->imm1 &= 0xffffffffU;
+        break;
+
     case ext_map5:
     case ext_map6:
     case ext_8f09:
-    case ext_8f0a:
         break;
 
     default:
-- 
2.49.0




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.