[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/hvm: Don't save or load HVM context of a domain with no vCPUs


  • To: Lin Liu <lin.liu01@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Teddy Astie <teddy.astie@xxxxxxxxxx>
  • Date: Wed, 18 Nov 2026 10:05:04 +0100
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID"
  • Autocrypt: addr=teddy.astie@xxxxxxxxxx; keydata= xsDNBGn5sK8BDACuzSrrTjpVf4ay06OYB6yY0J1PqKffihoNMtrQRZjAHxoAPC7LTBVHV/XO Zw5HJc+9R71z1JV+iYg6z3jPziGKzX8Fj3ZXlzJPmpf1PuETH3KdbvtJT4ny+OGntnJntUoR KRPhTirr6yNeBk/637O3CQXjtqFUPZnko8OI/o1yawIBhJJAWicutjkkUgd28Bh6HV9EIumH tCBgn5/1A/fpm9624MMgYLsA8qjC4XsoovQvFCaO8HEhvfzrrTZHjn/nPeB9SigxIxXW8YaT VqMdqul07o72m3eA2mf+LMu9a04FX/d4wbxBLtELm+1jIrbtyaFZEMOLv/haSiS/Lj3btJH/ EoucejoZ5SH49ksmVAmKOLktOaTQ8b2gEvP7iaKiIiszCCtOSRohr+2GvDsDeLvVZnlR3I+S PhHar7TPKjFz0G3DPNolyjXywNqOAMpomSPi8lSwjAFsxOtQbcck/qRGRSNk4DAmH70pA+89 MXfQXZ3qt1Q01B1+sU0I8xsAEQEAAc0kVGVkZHkgQXN0aWUgPHRlZGR5LmFzdGllQHZhdGVz LnRlY2g+wsENBBMBCAA3FiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmn5sK8FCQWjmoACGwME CwkIBwUVCAkKCwUWAgMBAAAKCRBmD6nRAsvP0ID6DACGOktArFbLKHNzuyOVCskwfUZPla6Z pd3GZ8r61SrAKePIr2BnpgPkd0hV3bSRkRLIrgjzR2NRCzfp0x0HfuhcYfAYPR46XHTvjaJE v99sT/vGUG1BZguYDOScSEpgSNaNlYum3RKZbMuROxdK8G+YHccJY8PvWSq2K2yiae2KGiAv 1yjnZxug9/PtDfX8vQFUSg2w1ukRDf50wvDohN1zUQfFtofOP2xCRsDZiHAlQ0pF+aUjXQhP eP3IdpfWc8cyRLXF06Rk46YMYCytweGtGdHcqAfrVthl84129ZPN422k/voW0sm14gjYlGcT UwgnYlFRk2FLq0QeKEDcS0aj3o3EVAQCrayoGzi1pnlIKE3PRGUcUzjGVvzQ/po24gOjwba9 Egr/Wmu3MQlx/7A8zT5QBzF/n+RYdLNQ0Eu6YnUwf0Z1uieqNaon+olyIRFiLb/hCZHO6ekN f5vrm2clHUbQAYaPQebknujoKBo6ZLHg0WM1gZS01Gz+aUpKsUfOwM0EafmwsAEMAKiQiZa3 yQMmc/h3sDbfVHPSiBA4IMI/NAB7IotzPHq1GzCpsoVILAhF/INbWjxJ3DbVf+en3/FvdVZg 2S38xtnth0njNdlVKpyxm054phKjbdoFDwaknWolS4hrddTmetSG5/52AjtmPFtlXAk0NmLv fJnW3seXVQbgM7sW/MNXPP5UKDpkGnLhnvej+GU0s3109sJeXT5ImVdphFs9cvyZyBT9t1Pb Rowv58EgV0zE4hbAeVkULAbxFV5b/ExTjjGVHoX7CVhWxvCiTqCUoXZRkUE9C3FnkzEFRkKb Yu6NCfiHfEyB3Xyg9hfdrRgjMRq907zCof+nDtWxGz1MSEuvTj1g9GZ049Bennqzjc/Q+0ov XoK4jm+Py0FiUGUaA6yhexficjH+kCR/xDbVnWrMhSLB4AuTBT9HjfZI6gk3uYLhoT8Pig4/ eVtR2Q1wZIJsFToR6ofGuyECwFcs+PUXN7fmGRSiPXgjAr/zIUBdW0VWCE3OGPNqtRk2E5s6 IQARAQABwsD8BBgBCAAmFiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmn5sLAFCQWjmoACGwwA CgkQZg+p0QLLz9DncQwAg76IehTemLIfrB8T9WIBZrI4kUV7G7a4rjiVoUiHYN5QwhnbZnsa JDlt+Ezoqy/510eo2bCSzvW5xXYPgyjcuOPwgQo1Qp764QxyX6rld2f2RcWkDuBHun55ZWXj by8o21ginPRwruBVYY5rVf3DV1iBu4NurUeHtyFk/dS0XTOQi2wVUb17sW/+ybCEokdVacZG zOqP/OmwHrF8ylXlXnhQq6e3r+J+T8fuoGJelm/CJiMwyP6cEWE8sxVqX/iqwjwUYkuOCpE+ lOWSvdNHgoEkWR0RXBPQjnGmLKbfTl/QDXLk6NP2/r9uxm2HL6Ei3QJKSEdrp+XZaVnk/Off O485NOTKwGOxyWb006cTMh53xPkAJFQu4Tvdj+odsHz88jqw5wfPG0BYWx0I/FspYj7N9kZR 8ULR9nX0LvpzJ/kB4NgHIUt8YtIL6ZSfM2dbF7fKzvx1UqFfvozJZwFzfEieJLXa4nlGgR6D x9fhaZEsniw8/bYgC3igkk5YJiOa
  • Cc: Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>
  • Delivery-date: Wed, 18 Nov 2026 09:05:30 +0000
  • Feedback-id: default:8631fc262581453bbf619ec5b2062170:Sweego
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Le 18/11/2026 à 08:06, Lin Liu a écrit :
> XEN_DOMCTL_createdomain allocates d->vcpu[] but the vCPUs themselves are
> only created by a later XEN_DOMCTL_max_vcpus.  In that window
> XEN_DOMCTL_gethvmcontext{,_partial} on the domain reach the per-domain
> save handlers with d->vcpu[0] == NULL.  A dom0 tool polling xen-hvmctx
> across all domains while a VM was being restored took the host down:
> 
>    (XEN) HVM d25 save: PIC
>    (XEN) RIP:    e008:[<ffff82d04030dc98>] 
> arch/x86/hvm/vpic.c#vpic_save+0x8/0x8f
>    (XEN) rdi: 0000000000000000
>    (XEN) Xen call trace:
>    (XEN)    [<ffff82d04030dc98>] R arch/x86/hvm/vpic.c#vpic_save+0x8/0x8f
>    (XEN)    [<ffff82d04021009f>] S arch/x86/hvm/save.c#hvm_save.cold+0x9b/0xf7
>    (XEN)    [<ffff82d04036d99c>] S arch_do_domctl+0x1a2c/0x28a6
>    (XEN)    [<ffff82d04025341a>] S do_domctl+0x139a/0x1642
>    (XEN)    [<ffff82d04033331e>] S pv_hypercall+0x3ae/0x59a
>    (XEN)    [<ffff82d0402003b5>] S lstar_enter+0x105/0x10a
>    (XEN)
>    (XEN) Panic on CPU 0:
>    (XEN) FATAL PAGE FAULT
>    (XEN) [error_code=0000]
>    (XEN) Faulting linear address: 0000000000000018
> 
> XEN_DOMCTL_sethvmcontext has the same problem on the load side, e.g.
> pit_load() uses d->vcpu[0] for the guest time.
> 
> Refuse to save or load the whole context until vCPU 0 exists, and look up
> the vCPU in hvm_save_one() with domain_vcpu(), failing with -ENOENT as
> for other absent vCPUs.
> 
> Fixes: d0d8980138c4 ("x86/hvm: remove redundant save functions")
> Assisted-by: Claude:claude-opus-5
> Signed-off-by: Lin Liu <lin.liu01@xxxxxxxxxx>
> ---
>   xen/arch/x86/hvm/save.c | 15 ++++++++-------
>   1 file changed, 8 insertions(+), 7 deletions(-)
> 
> diff --git a/xen/arch/x86/hvm/save.c b/xen/arch/x86/hvm/save.c
> index 8ab6405706..48f8229061 100644
> --- a/xen/arch/x86/hvm/save.c
> +++ b/xen/arch/x86/hvm/save.c
> @@ -139,12 +139,11 @@ int hvm_save_one(struct domain *d, unsigned int 
> typecode, unsigned int instance,
>            !hvm_sr_handlers[typecode].save )
>           return -EINVAL;
>   
> -    if ( hvm_sr_handlers[typecode].kind != HVMSR_PER_VCPU )
> -        v = d->vcpu[0];
> -    else if ( instance >= d->max_vcpus || !d->vcpu[instance] )
> +    /* Per-domain records are saved via vCPU 0, absent before max_vcpus. */
> +    v = domain_vcpu(d, hvm_sr_handlers[typecode].kind == HVMSR_PER_VCPU
> +                       ? instance : 0);
> +    if ( !v )
>           return -ENOENT;
> -    else
> -        v = d->vcpu[instance];
>       ctxt.size = hvm_sr_handlers[typecode].size;
>       ctxt.data = xmalloc_bytes(ctxt.size);
>       if ( !ctxt.data )
> @@ -203,7 +202,8 @@ int hvm_save(struct domain *d, hvm_domain_context_t *h)
>       struct hvm_save_end end;
>       unsigned int i;
>   
> -    if ( d->is_dying )
> +    /* Per-domain handlers are passed vCPU 0. */
> +    if ( d->is_dying || !d->vcpu[0] )
>           return -EINVAL;
>   
>       hdr.magic = HVM_FILE_MAGIC;
> @@ -291,7 +291,8 @@ int hvm_load(struct domain *d, bool real, 
> hvm_domain_context_t *h)
>       struct hvm_save_descriptor *desc;
>       int rc;
>   
> -    if ( d->is_dying )
> +    /* Some per-domain loaders use vCPU 0. */
> +    if ( d->is_dying || !d->vcpu[0] )
>           return -EINVAL;
>   
>       /* Get at the save header, which must be first */

Reviewed-by: Teddy Astie <teddy.astie@xxxxxxxxxx>

We probably want to refactor parts of this function to avoid duplication 
(repeated hvm_sr_handlers[typecode], hvm_sr_handlers[typecode].kind == 
HVMSR_PER_VCPU, ...). But that's better done in a separate patch.

Teddy


--
Teddy Astie | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.