[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4] automation/eclair: deviate R2.6 for the x86 emulator


  • To: "Chen, Shuaidong" <Shuaidong.Chen@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 18 Nov 2026 08:51:49 +0100
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID"
  • Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>, Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 18 Nov 2026 07:51:53 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 18.11.2026 04:16, Chen, Shuaidong wrote:
> On 11/16/2026 11:17 AM, Shuaidong Chen wrote:
>> MISRA C:2012 Rule 2.6 (advisory) states that "a function should not
>> contain unused label declarations".
>>
>> Depending on which parts of the x86 emulator are compiled in, some of
>> its labels end up with no goto targeting them.  For example, with
>> CONFIG_HVM=n private.h defines X86EMUL_NO_FPU, X86EMUL_NO_MMX and
>> X86EMUL_NO_SIMD: the CASE_SIMD_* macros then expand to plain labels
>> instead of case labels, and the gotos to several hand-written simd_*
>> labels are preprocessed out, leaving 91 unused labels in
>> x86_emulate.c.  The build already acknowledges this by passing
>> -Wno-unused-label for that object.
>>
>> Annotating these labels would only add churn to the emulator.  As done
>> for Rule 16.2, deviate the rule for the emulator as a whole.
>>
>> Signed-off-by: Shuaidong Chen <shuaidong.chen@xxxxxxx>
>> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
>> Acked-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
>> ---
>> v4:
>> - Reuse the existing x86_emulate file tag, moving its definition ahead
>>    of its first use.
>>
>> v3:
>> - Drop the CONFIG_HVM=n specifics from the deviation text, as the
>>    deviation itself isn't limited to that configuration.
>>
>> v2:
>> - Drop the __maybe_unused annotations (v1 patch 1) and the CASE_SIMD_*
>>    specific deviation (v1 patch 2) in favour of an emulator-wide
>>    deviation, following the existing one for Rule 16.2.
>> - Trim the Cc list.
>>
>>   automation/eclair_analysis/ECLAIR/deviations.ecl | 7 ++++++-
>>   docs/misra/deviations.rst                        | 8 ++++++++
>>   2 files changed, 14 insertions(+), 1 deletion(-)
>>
>> diff --git a/automation/eclair_analysis/ECLAIR/deviations.ecl 
>> b/automation/eclair_analysis/ECLAIR/deviations.ecl
>> index 296340bb4c..d49af53055 100644
>> --- a/automation/eclair_analysis/ECLAIR/deviations.ecl
>> +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl
>> @@ -55,6 +55,12 @@ removed by the compiler, the resulting slowdown is 
>> negligible."
>>   -config=MC3A2.R2.6,reports+={deliberate, 
>> "any_area(text(^.*__maybe_unused.*$))"}
>>   -doc_end
>>   
>> +-doc_begin="Depending on which parts of the x86 emulator are compiled in, 
>> some of its labels, many of them generated by the CASE_SIMD_* macros, may 
>> end up with no goto targeting them.
>> +Annotating them would only add churn to the emulator, therefore it is 
>> deemed better to leave such files as is."
>> +-file_tag+={x86_emulate,"^xen/arch/x86/x86_emulate/.*$"}
>> +-config=MC3A2.R2.6,reports+={deliberate, 
>> "any_area(any_loc(file(x86_emulate)))"}
>> +-doc_end
>> +
>>   #
>>   # Series 3.
>>   #
>> @@ -531,7 +537,6 @@ therefore have the same behavior of a boolean"
>>   
>>   -doc_begin="Complying with the Rule would entail a lot of code duplication 
>> in the implementation of the x86 emulator,
>>   therefore it is deemed better to leave such files as is."
>> --file_tag+={x86_emulate,"^xen/arch/x86/x86_emulate/.*$"}
>>   -file_tag+={x86_svm_emulate,"^xen/arch/x86/hvm/svm/emulate\\.c$"}
>>   -config=MC3A2.R16.2,reports+={deliberate, 
>> "any_area(any_loc(file(x86_emulate||x86_svm_emulate)))"}
>>   -doc_end
>> diff --git a/docs/misra/deviations.rst b/docs/misra/deviations.rst
>> index bee4686675..7b983db264 100644
>> --- a/docs/misra/deviations.rst
>> +++ b/docs/misra/deviations.rst
>> @@ -116,6 +116,14 @@ Deviations related to MISRA C:2012 Rules:
>>          such labels poses no risks.
>>        - Tagged as `deliberate` for ECLAIR.
>>   
>> +   * - R2.6
>> +     - Depending on which parts of the x86 emulator are compiled in, some of
>> +       its labels, many of them generated by the CASE_SIMD_* macros, may end
>> +       up with no goto targeting them. Annotating them would only add churn
>> +       to the emulator, therefore it is deemed better to leave such files as
>> +       is.
>> +     - Tagged as `deliberate` for ECLAIR.
>> +
>>      * - R3.1
>>        - Comments starting with '/\*' and containing URLs are safe as they 
>> are
>>          not instances of commented-out code.
> 
> any other comments on this?

Before asking, did you check the tree?

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.