[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/4] automation/eclair: deviate MISRA C Rule 11.8 for xfree() and vfree()


  • To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 18 Nov 2026 08:49:12 +0100
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID"
  • Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
  • Cc: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Delivery-date: Wed, 18 Nov 2026 07:49:23 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 17.11.2026 23:35, Stefano Stabellini wrote:
> On Tue, 17 Nov 2026, Andrew Cooper wrote:
>> On 17/11/2026 8:01 pm, Dmytro Prokopchuk wrote:
>>> On 11/4/26 13:24, Andrew Cooper wrote:
>>>> On 03/11/2026 10:29 am, Dmytro Prokopchuk1 wrote:
>>>>> Livepatch passes const-qualified pointers from struct payload to
>>>>> xfree()
>>>>> and vfree(), which take a 'void *' argument. The cast that removes the
>>>>> const qualifier is a violation of MISRA C Rule 11.8.
>>>>>
>>>>> Such casts are safe.  The deallocation functions neither read nor write
>>>>> the content of the object being freed, and the object is not accessed
>>>>> after it has been freed.
>>>>
>>>> I have a very firm objection to this.
>>>>
>>>> It is impossible for any allocation from malloc()/calloc()/etc to point
>>>> to read-only memory, which is why free() takes a mutable pointer, not a
>>>> const pointer.  The same is true of any other heap implementation.
>>>>
>>>> It is impossible to make an object in read-only memory undefined.
>>>> Objects in read-only memory by definition have a global lifetime, and it
>>>> is absurd to argue that a specific heap implementation ought to permit
>>>> making such objects undefined.
>>>>
>>>>
>>>> The bug here is livepatch storing a heap allocation in a const pointer.
>>>>
>>>> This comes from deeper problem where some contributors/reviewers want
>>>> the const keyword to mean something it doesn't.
>>>>
>>>> ~Andrew
>>>
>>> Jan, Andrew,
>>>
>>> thanks for the review.  Given the disagreement, I will drop this
>>> deviation for now.
>>>
>>> If the preferred fix is to stop storing heap allocations in
>>> const-qualified members of 'struct payload' (so the casts go away), I
>>> can prepare a follow-up patch.  Please confirm that is the direction
>>> you want for livepatch.
>>
>> Please remove the const qualification in struct payload.  The logic
>> should not have been accepted in that state to begin with.
>>
>> This is the only course of action here which does not create a class of
>> undefined behaviour, or permit said undefined behaviour to go unnoticed.
> 
> I agree with Andrew. xfree() does write into the freed block, so a
> const parameter would be misleading.

Well, this is the point: Yes, xfree() modifies the underlying memory. But
no, it does not modify the object a pointer to which was passed into it.
That object simply ceases to exist. And what C is concerned about are
objects, not the underlying memory.

I also still don't quite understand why Andrew considers such uses of
const wrong: I don't think the spec says anything in this regard, and the
C library's free() taking plain void * can easily be seen as heritage.
Using const like this properly conveys to compiler and readers that post-
allocation / -population such objects aren't supposed to be altered
again. Together with forbidding the casting away of const-ness, this
serves as an extra level of safety of the code overall.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.