|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH 1/4] libacpi: Build TPM2 tables for the TIS interface
On 18.11.2026 02:15, Jason Andryuk wrote:
> On 2026-11-16 08:30, Jan Beulich wrote:
>> On 07.11.2026 00:15, Jason Andryuk wrote:
>
>>> @@ -444,17 +445,30 @@ static int construct_secondary_tables(struct
>>> acpi_ctxt *ctxt,
>>> break;
>>>
>>> case 2:
>>> - /*
>>> - * Check VID stored in bits 37:32 (3rd 16 bit word) of CRB
>>> - * identifier register. See table 16 of TCG PC client platform
>>> - * TPM profile specification for TPM 2.0.
>>> - */
>>> - if ( config->crb_id[2] == 0 || config->crb_id[2] == 0xffff )
>>> - break;
>>> + if ( config->tpm_interface == ACPI_TPM_INTERFACE_TIS )
>>
>> Better use switch() right away?
>
> Well, I don't expect there to be more than these two on x86.
I see. Something assert()-like on the else path may then be nice, except that
the way libacpi is used (and there being no abstraction of it) this may not be
possible in practice.
>>> --- /dev/null
>>> +++ b/tools/libacpi/ssdt_tpm2_tis.asl
>>> @@ -0,0 +1,25 @@
>>> +/* SPDX-License-Identifier: LGPL-2.1-only */
>>> +/*
>>> + * ssdt_tpm2_tis.asl
>>> + */
>>> +
>>> +/* SSDT for TPM 2.0 TIS Interface for Xen with Qemu device model. */
>>> +
>>> +DefinitionBlock ("SSDT_TPM2_TIS.aml", "SSDT", 2, "Xen", "HVM", 0)
>>> +{
>>> + Device (TPM)
>>> + {
>>> + Name (_HID, "MSFT0101" /* TPM 2.0 Security Device */) // _HID:
>>> Hardware ID
>>> + Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
>>> + {
>>> + Memory32Fixed (ReadWrite,
>>> + 0xFED40000, // Address Base
>>> + 0x00005000, // Address Length
>>> + )
>>
>> I know you're only following what we do elsewhere (i.e. this isn't a
>> request for you to change anything), but I wonder how we could make sure
>> that such seemingly arbitrary address range allocations won't ever
>> conflict. (I assume the base address is dictated by qemu?)
>
> Yes, it is a hardcoded address in QEMU for TPM-TIS. More generally,
> 0xfed4xxxx is standardized by the Trusted Computing Group for TPM TIS on
> x86.
>
> ARM defines assorted GUEST_* values for ram and mmio. Something like
> that could be done for x86. Though using them in an .asl file isn't
> friendly. TPM_REGISTER_BASE is already a define. That could be placed
> in the comment at least?
Yes, this would then also serve as grep fodder.
Jan
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |