[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/4] libacpi: Build TPM2 tables for the TIS interface


  • To: Jason Andryuk <jason.andryuk@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 18 Nov 2026 08:34:01 +0100
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:Content-Type:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID"
  • Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
  • Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 18 Nov 2026 07:34:12 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 18.11.2026 02:15, Jason Andryuk wrote:
> On 2026-11-16 08:30, Jan Beulich wrote:
>> On 07.11.2026 00:15, Jason Andryuk wrote:
> 
>>> @@ -444,17 +445,30 @@ static int construct_secondary_tables(struct 
>>> acpi_ctxt *ctxt,
>>>               break;
>>>   
>>>           case 2:
>>> -            /*
>>> -             * Check VID stored in bits 37:32 (3rd 16 bit word) of CRB
>>> -             * identifier register.  See table 16 of TCG PC client platform
>>> -             * TPM profile specification for TPM 2.0.
>>> -             */
>>> -            if ( config->crb_id[2] == 0 || config->crb_id[2] == 0xffff )
>>> -                break;
>>> +            if ( config->tpm_interface == ACPI_TPM_INTERFACE_TIS )
>>
>> Better use switch() right away?
> 
> Well, I don't expect there to be more than these two on x86.

I see. Something assert()-like on the else path may then be nice, except that
the way libacpi is used (and there being no abstraction of it) this may not be
possible in practice.

>>> --- /dev/null
>>> +++ b/tools/libacpi/ssdt_tpm2_tis.asl
>>> @@ -0,0 +1,25 @@
>>> +/* SPDX-License-Identifier: LGPL-2.1-only */
>>> +/*
>>> + * ssdt_tpm2_tis.asl
>>> + */
>>> +
>>> +/* SSDT for TPM 2.0 TIS Interface for Xen with Qemu device model. */
>>> +
>>> +DefinitionBlock ("SSDT_TPM2_TIS.aml", "SSDT", 2, "Xen", "HVM", 0)
>>> +{
>>> +    Device (TPM)
>>> +    {
>>> +        Name (_HID, "MSFT0101" /* TPM 2.0 Security Device */)  // _HID: 
>>> Hardware ID
>>> +        Name (_CRS, ResourceTemplate ()  // _CRS: Current Resource Settings
>>> +        {
>>> +            Memory32Fixed (ReadWrite,
>>> +                0xFED40000,         // Address Base
>>> +                0x00005000,         // Address Length
>>> +                )
>>
>> I know you're only following what we do elsewhere (i.e. this isn't a
>> request for you to change anything), but I wonder how we could make sure
>> that such seemingly arbitrary address range allocations won't ever
>> conflict. (I assume the base address is dictated by qemu?)
> 
> Yes, it is a hardcoded address in QEMU for TPM-TIS.  More generally, 
> 0xfed4xxxx is standardized by the Trusted Computing Group for TPM TIS on 
> x86.
> 
> ARM defines assorted GUEST_* values for ram and mmio.  Something like 
> that could be done for x86.  Though using them in an .asl file isn't 
> friendly.  TPM_REGISTER_BASE is already a define.  That could be placed 
> in the comment at least?

Yes, this would then also serve as grep fodder.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.