[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86emul: Don't adjust the memory operand of BT* with an immediate offset


  • To: Jan Beulich <jbeulich@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Stephen Cheng <stephen.cheng@xxxxxxxxxx>
  • Date: Wed, 18 Nov 2026 11:26:20 +0800
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UgQW+a5+U+C/hOOK92YZNHBLzUcHumuI4nc4gk+AdE8=; b=qlpuuqBeC6dyh8iiWNoBK7BRC52vISimuC9avwkMU5LkRWTrhQjRjOBHKbH4DAA6I5wvrHQW4PloP0wsveptMyRhcKvHybLlHgSztN9sOs6TGDLYzmDdIugbptRVZxxut4v+AjNP/Ic0wgLTH47vfUjqj8ojsF3YVAxKTSwzxq25dLfSI1rc2MUBUiR2K5kGUV4Z7LhNprMoxMrT4p40hnWd26Fv+h6Q6H1DpMdZl4PSwUDvlkmvTjEcbpLTtIBMolBvDcrdR2GxYINgpz/rYWrTg286XhG17QP07uDBOTxknsaFtoGVIhbR0LSbO2NljAkqFkpX5/crDIfGA2GpNQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JD5r9xtuEkxb3IVd+zGFJ4myLd5LM4mcCvcxnrjDpUUbIbSmiDXLewVDeeCNoMOE5vIXfISgMmZ0O54k7kxnHCIDDDAV3me3Xl2jW2SBHqJo7LpM92Et/BBtIcsrGuP8EcbmCKuXFaxZTorr/1ATP42lGw7WBYVeXH0+XB4EjFvJ6myao+0t3nzHFbLFPQ3fZe1sNUXIxH278cfDmdE8lUyeB/uJsrdPqhv0MA3mBeB4A6zg0hCmz7eq/EHmVy8GXZoloZ1P5j4Ji0Awy19sgZ0sgRoUKj0MMLqgI+6MwrMQS0zAPO0XBeUTU5FiTWwAp01i8AbSnA9D7srnC+dW0g==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger@xxxxxxxxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Stephen Cheng <stephen.cheng@xxxxxxxxxx>
  • Delivery-date: Wed, 18 Nov 2026 03:26:46 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 17.11.2026 11:11, Jan Beulich wrote:
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> with a remark towards the description: I question "accidentally", when
> the description of the offending patch says "... and simplify the entry
> condition for adjusting the memory operand." I'm inclined to change the
> word to "mistakenly" when committing.

Thanks for the review. You are right, the change was intended, so
"mistakenly" is better. Please change it when committing.

Stephen



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.