[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 3/4] xen/arm: traps: enter the SP_EL0 vector group for an exception at EL1t
- To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Stefano Stabellini <stefano.stabellini@xxxxxxx>
- Date: Tue, 17 Nov 2026 16:59:02 -0800
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U05Nx9cqADRaNyGYvpkNwv1VsbDKFsTvDwYvYUs/CE4=; b=uYTZQHMUt7q2nILwGFpLZlWVuqdgqTp/XVwtMzyZW3/xAlOnQuHz0QqN2Uu99EY8X+3FjhA8JcSixfISGMvob7cvb0aZXD8NFuwR3g3LDbds9OgI0LDTpFCTt+KZuOe8zwnNi2nMLzwg5csv+nV+sEu34wwqojlmiR03hcnMOfkt6gZdi7utpNxA35BTKnrMtqMYEYT1iEa0KKnkWQRNOLKVE2ZNlbAVhu0SA9AgkMs1Gc1ZFbZL0kcBAubLpS8g6vfSHnGd4mvJoIfNHrY9ciyw6ZBg+/jbsJ1dsdDQ3UezHIzDbV+GgikzkeAgqIwmzf7gDyu8NO1K6+dOytrlZw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qJMUT57KQ6ZObM8kGRD1vAqxL840XkzRSPoDuAFfxNCvzf68kVg4HkxmoH3I1eczjKt3k1BCNPNoielo2TgW5qqFrePgPLtRXNrfVuJd4riLOf9UjAIaZGCEDVZT0xMcaWfsoLka8FTcXk17X3Rqutt/QFEMI/ROYlSNRQwo7kbv+tnRJp9VL58aO0AnkJFN+/f/MzUmY0ktUN/cWjtkTwoqTwrkJdim3puLWqe0H//EgMEUEoAXlNWsqbMIlJZAUraYsAQVKQnCbDLhh7tzeJmzJNrCC8mKh4l+CooYNfIIcgF+InnNQe4ZqyRqngxVsboYro5Em9LbSnvc8xg2CQ==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Cc: <stefano.stabellini@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "Julien Grall" <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 18 Nov 2026 00:59:20 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
An exception taken from the current level is delivered to the SP_EL0
vector group (offset 0x000) when the guest was at EL1t, and to the
SP_ELx group (0x200) only at EL1h (ARM DDI 0487 M.d D1.4.1).
exception_handler64() used 0x200 for both.
Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
---
Cc: Julien Grall <julien@xxxxxxx>
Cc: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cc: Michal Orzel <michal.orzel@xxxxxxx>
Cc: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
Changes in v2:
- Cite ARM DDI 0487 M.d D1.4.1 instead of A.k, in the commit message
and the comment.
- Move the Cc list after ---.
- Add Michal's Reviewed-by.
---
xen/arch/arm/traps.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index 47a5c6bdd4..b4ca812233 100644
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
@@ -532,7 +532,13 @@ static vaddr_t exception_handler64(struct cpu_user_regs
*regs, vaddr_t offset)
base += VECTOR64_LOWER32_BASE;
else if ( psr_mode(regs->cpsr,PSR_MODE_EL0t) )
base += VECTOR64_LOWER64_BASE;
- else /* Otherwise must be from kernel mode */
+ /*
+ * Otherwise must be from kernel mode. The current EL group is chosen by
+ * the stack pointer in use (ARM DDI 0487 M.d D1.4.1).
+ */
+ else if ( psr_mode(regs->cpsr,PSR_MODE_EL1t) )
+ base += VECTOR64_CURRENT_SP0_BASE;
+ else
base += VECTOR64_CURRENT_SPx_BASE;
return base + offset;
--
2.47.3
|