|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH 3/4] xen: resolve MISRA C Rule 11.8 in xen_build_id_check()
On 11/3/26 13:16, Jan Beulich wrote: On 03.11.2026 11:29, Dmytro Prokopchuk1 wrote:ELFNOTE_NAME() unconditionally casts its argument to 'char *', and ELFNOTE_DESC() is built on top of it. xen_build_id_check() passes a 'const Elf_Note *' to both of them, so the const qualifier is cast away, which is a violation of MISRA C Rule 11.8. Introduce ELFNOTE_NAME_CONST() and ELFNOTE_DESC_CONST() for read-only access to the note, and use them in xen_build_id_check(). No functional changes. Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx>It again would have been nice if it was mentioned that this is an alternative proposal to an earlier posted patch, [1]. Personally here I prefer my variant (with the adjustment as per review feedback, pending a v2 submission). Jan [1] https://lists.xen.org/archives/html/xen-devel/2026-09/msg00045.html Sorry for not referencing [1]. I will drop this patch and wait for your v2.
BR, Dmytro.
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |