[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] xen/blkback: Fix memory leak in xen_blkif_init()



If xen_blkif_xenbus_init() fails, xen_blkif_init() returns without
destroying the slab cache created by xen_blkif_interface_init().

Call xen_blkif_interface_fini() on this error path.

Fixes: 8770b2683f9f ("Fix compile warnings: ignoring return value of 
'xenbus_register_backend' ..")
Signed-off-by: Haoxiang Li <haoxiang_li2024@xxxxxxx>
---
 drivers/block/xen-blkback/blkback.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/xen-blkback/blkback.c 
b/drivers/block/xen-blkback/blkback.c
index 88526e349ce1..6c25da65e46e 100644
--- a/drivers/block/xen-blkback/blkback.c
+++ b/drivers/block/xen-blkback/blkback.c
@@ -1553,7 +1553,7 @@ static int __init xen_blkif_init(void)
 
        rc = xen_blkif_xenbus_init();
        if (rc)
-               goto failed_init;
+               xen_blkif_interface_fini();
 
  failed_init:
        return rc;
-- 
2.25.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.